From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02105C2BA4C for ; Wed, 26 Jan 2022 12:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241215AbiAZMWi (ORCPT ); Wed, 26 Jan 2022 07:22:38 -0500 Received: from foss.arm.com ([217.140.110.172]:36110 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234079AbiAZMWg (ORCPT ); Wed, 26 Jan 2022 07:22:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69FA6D6E; Wed, 26 Jan 2022 04:22:36 -0800 (PST) Received: from [10.57.5.122] (unknown [10.57.5.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BEC863F793; Wed, 26 Jan 2022 04:22:35 -0800 (PST) Subject: Re: [PATCH 2/5] kselftest: Fix vdso_test_time to pass on skips To: Cristian Marussi , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shuah@kernel.org References: <20220126102723.23300-1-cristian.marussi@arm.com> <20220126102723.23300-3-cristian.marussi@arm.com> From: Vincenzo Frascino Message-ID: <8d513be7-a99d-2b7f-6767-a378742ef3fa@arm.com> Date: Wed, 26 Jan 2022 12:22:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220126102723.23300-3-cristian.marussi@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cristian, On 1/26/22 10:27 AM, Cristian Marussi wrote: > When a vDSO symbol is not found, all the testcases in vdso_test_abi usually > report a SKIP, which, in turn, is reported back to Kselftest as a PASS. > > Testcase vdso_test_time, instead, reporting a SKIP, causes the whole set of > tests within vdso_test_abi to be considered FAIL when symbol is not found. > > Fix it reporting a PASS when vdso_test_time cannot find the vdso symbol. > > Cc: Vincenzo Frascino > Signed-off-by: Cristian Marussi > --- > Seen as a failure on both a JUNO and a Dragonboard on both recent and old > kernels/testruns: > > root@deb-buster-arm64:~# /opt/ksft/vDSO/vdso_test_abi > [vDSO kselftest] VDSO_VERSION: LINUX_2.6.39 > The time is 1637922136.675304 > The time is 1637922136.675361000 > The resolution is 0 1 > clock_id: CLOCK_REALTIME [PASS] > The time is 1927.760604900 > The resolution is 0 1 > clock_id: CLOCK_BOOTTIME [PASS] > The time is 1637922136.675649700 > The resolution is 0 1 > clock_id: CLOCK_TAI [PASS] > The time is 1637922136.672000000 > The resolution is 0 4000000 > clock_id: CLOCK_REALTIME_COARSE [PASS] > The time is 1927.761005600 > The resolution is 0 1 > clock_id: CLOCK_MONOTONIC [PASS] > The time is 1927.761132780 > The resolution is 0 1 > clock_id: CLOCK_MONOTONIC_RAW [PASS] > The time is 1927.757093740 > The resolution is 0 4000000 > clock_id: CLOCK_MONOTONIC_COARSE [PASS] > Could not find __kernel_time <<< This caused a FAIL as a whole > root@deb-buster-arm64:~# echo $? > 1 > > e.g.: https://lkft.validation.linaro.org/scheduler/job/2192570#L27778 > --- > tools/testing/selftests/vDSO/vdso_test_abi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vDSO/vdso_test_abi.c b/tools/testing/selftests/vDSO/vdso_test_abi.c > index 3d603f1394af..7dcc66d1cecf 100644 > --- a/tools/testing/selftests/vDSO/vdso_test_abi.c > +++ b/tools/testing/selftests/vDSO/vdso_test_abi.c > @@ -90,8 +90,9 @@ static int vdso_test_time(void) > (vdso_time_t)vdso_sym(version, name[2]); > > if (!vdso_time) { > + /* Skip if symbol not found: consider skipped tests as passed */ > printf("Could not find %s\n", name[2]); > - return KSFT_SKIP; > + return KSFT_PASS; My preference would be to keep "KSFT_SKIP" here and verify separately the return status of each test. This would maintain compliance with the kselftest API. Could you please test the patch in-reply-to this one (will be sent shortly) and let me know if it works for you? If it does feel free to fold it in the next version of your series with your "Tested-by:" otherwise let me know. Thanks! > } > > long ret = vdso_time(NULL); > -- Regards, Vincenzo