linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Roman Kagan" <rkagan@virtuozzo.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Stephen Hemminger" <sthemmin@microsoft.com>,
	"Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
	"Jim Mattson" <jmattson@google.com>,
	"Liran Alon" <liran.alon@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 09/12] x86/kvm/nVMX: allow bare VMXON state migration
Date: Mon, 15 Oct 2018 19:09:35 +0200	[thread overview]
Message-ID: <8d6b85c4-16c6-cbde-22ec-ee61df0c49fd@redhat.com> (raw)
In-Reply-To: <20180913170522.24876-10-vkuznets@redhat.com>

On 13/09/2018 19:05, Vitaly Kuznetsov wrote:
> It is perfectly valid for a guest to do VMXON and not do VMPTRLD. This
> state needs to be preserved on migration.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Please cover this in state-test.c too.

Paolo

> ---
>  arch/x86/kvm/vmx.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index d3297fadf7ed..25a25fff8dd9 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14482,13 +14482,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>  	if (!page_address_valid(vcpu, kvm_state->vmx.vmxon_pa))
>  		return -EINVAL;
>  
> -	if (kvm_state->size < sizeof(kvm_state) + sizeof(*vmcs12))
> -		return -EINVAL;
> -
> -	if (kvm_state->vmx.vmcs_pa == kvm_state->vmx.vmxon_pa ||
> -	    !page_address_valid(vcpu, kvm_state->vmx.vmcs_pa))
> -		return -EINVAL;
> -
>  	if ((kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_GUEST_MODE) &&
>  	    (kvm_state->flags & KVM_STATE_NESTED_GUEST_MODE))
>  		return -EINVAL;
> @@ -14510,6 +14503,14 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>  	if (ret)
>  		return ret;
>  
> +	/* Empty 'VMXON' state is permitted */
> +	if (kvm_state->size < sizeof(kvm_state) + sizeof(*vmcs12))
> +		return 0;
> +
> +	if (kvm_state->vmx.vmcs_pa == kvm_state->vmx.vmxon_pa ||
> +	    !page_address_valid(vcpu, kvm_state->vmx.vmcs_pa))
> +		return -EINVAL;
> +
>  	set_current_vmptr(vmx, kvm_state->vmx.vmcs_pa);
>  
>  	if (kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_VMXON) {
> 


  parent reply	other threads:[~2018-10-15 17:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 17:05 [PATCH v5 00/12] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 01/12] KVM: hyperv: define VP assist page helpers Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 02/12] KVM: VMX: refactor evmcs_sanitize_exec_ctrls() Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 03/12] KVM: nVMX: add KVM_CAP_HYPERV_ENLIGHTENED_VMCS capability Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 04/12] KVM: nVMX: add enlightened VMCS state Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 05/12] KVM: nVMX: implement enlightened VMPTRLD and VMCLEAR Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 06/12] KVM: nVMX: optimize prepare_vmcs02{,_full} for Enlightened VMCS case Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 07/12] x86/kvm/hyperv: don't clear VP assist pages on init Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 08/12] x86/kvm/lapic: preserve gfn_to_hva_cache len on cache reinit Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 09/12] x86/kvm/nVMX: allow bare VMXON state migration Vitaly Kuznetsov
2018-09-13 19:21   ` Jim Mattson
2018-09-14  7:49     ` Vitaly Kuznetsov
2018-09-14 16:51       ` Jim Mattson
2018-10-15 17:09   ` Paolo Bonzini [this message]
2018-10-16 13:59     ` Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 10/12] x86/kvm/nVMX: nested state migration for Enlightened VMCS Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 11/12] tools/headers: update kvm.h Vitaly Kuznetsov
2018-09-13 17:05 ` [PATCH v5 12/12] KVM: selftests: add Enlightened VMCS test Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d6b85c4-16c6-cbde-22ec-ee61df0c49fd@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Michael.H.Kelley@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liran.alon@oracle.com \
    --cc=rkagan@virtuozzo.com \
    --cc=rkrcmar@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).