From: Vlastimil Babka <vbabka@suse.cz>
To: Borislav Petkov <bp@alien8.de>, Michal Hocko <mhocko@kernel.org>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check
Date: Mon, 16 Jan 2017 11:08:36 +0100 [thread overview]
Message-ID: <8d76806c-1413-a412-253a-896394c09d5a@suse.cz> (raw)
In-Reply-To: <20170116091643.15260-1-bp@alien8.de>
On 01/16/2017 10:16 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> We wanna know who's doing such a thing. Like slab.c does that.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/slub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 067598a00849..1b0fa7625d6d 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
> flags &= ~GFP_SLAB_BUG_MASK;
> pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
> invalid_mask, &invalid_mask, flags, &flags);
> + dump_stack();
> }
>
> return allocate_slab(s,
>
prev parent reply other threads:[~2017-01-16 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 9:16 [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov
2017-01-16 9:28 ` Leon Romanovsky
2017-01-16 9:37 ` Borislav Petkov
2017-01-16 9:48 ` Leon Romanovsky
2017-01-16 9:55 ` Borislav Petkov
2017-01-16 10:09 ` Leon Romanovsky
2017-01-16 10:13 ` Borislav Petkov
2017-01-16 10:18 ` Leon Romanovsky
2017-01-16 9:59 ` Michal Hocko
2017-01-16 9:38 ` Michal Hocko
2017-01-16 10:08 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d76806c-1413-a412-253a-896394c09d5a@suse.cz \
--to=vbabka@suse.cz \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).