From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: <jeyu@kernel.org>, <rusty@rustcorp.com.au>,
<kay.sievers@vrfy.org>, <clabbe.montjoie@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
"wangxiaogang (F)" <wangxiaogang3@huawei.com>,
"Zhoukang (A)" <zhoukang7@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>
Subject: [PATCH] module: add usage links when calling ref_module func
Date: Fri, 28 Jun 2019 20:32:18 +0800 [thread overview]
Message-ID: <8d7aa8b1-73a2-db7a-82c8-06917eddf235@huawei.com> (raw)
From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Problem: Users can call ref_module func in their modules to construct
relationships with other modules. However, the holders
'/sys/module/<mod-name>/holders' of the target module donot include
the users` module. So lsmod command misses detailed info of 'Used by'.
When load module, the process is given as follows,
load_module()
-> mod_sysfs_setup()
-> add_usage_links
-> do_init_module
-> mod->init()
add_usage_links func creates holders of target modules linking to
this module. If ref_module is called in mod->init() func, the usage
links cannot be added.
Here, we will add usage link of a to b's holder_dir.
Fixes: 9bea7f239 ("module: fix bne2 "gave up waiting for init of module libcrc32c")
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
kernel/module.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kernel/module.c b/kernel/module.c
index 80c7c09584cf..11c6aff37b1f 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -871,6 +871,11 @@ int ref_module(struct module *a, struct module *b)
module_put(b);
return err;
}
+
+ err = sysfs_create_link(b->holders_dir, &a->mkobj.kobj, a->name);
+ if (err)
+ return err;
+
return 0;
}
EXPORT_SYMBOL_GPL(ref_module);
--
2.19.1
next reply other threads:[~2019-06-28 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:32 Zhiqiang Liu [this message]
2019-07-01 13:55 ` [PATCH] module: add usage links when calling ref_module func Jessica Yu
2019-07-03 1:28 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d7aa8b1-73a2-db7a-82c8-06917eddf235@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=clabbe.montjoie@gmail.com \
--cc=jeyu@kernel.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=rusty@rustcorp.com.au \
--cc=wangxiaogang3@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).