From: Wolfgang Grandegger <wg@grandegger.com>
To: Dan Murphy <dmurphy@ti.com>, mkl@pengutronix.de, davem@davemloft.net
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework
Date: Wed, 24 Oct 2018 09:43:19 +0200 [thread overview]
Message-ID: <8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com> (raw)
In-Reply-To: <e8485e2e-df04-0905-7055-c2228c0f1fa4@ti.com>
Hallo Dan,
I will have a closer look later this week. Unfortunately you already
renamed file names and structs making the patch almost unreadable. More
soon..
Thanks for you patience,
Wolfgang.
Am 17.10.2018 um 22:21 schrieb Dan Murphy:
> Bump
>
> On 10/10/2018 09:20 AM, Dan Murphy wrote:
>> All
>>
>> This patch series creates a m_can core framework that devices can register
>> to. The m_can core manages the Bosch IP and CAN frames. Each device that
>> is registered is responsible for managing device specific functions.
>>
>> This rewrite was suggested in a device driver submission for the TCAN4x5x
>> device
>> Reference upstream post:
>> https://lore.kernel.org/patchwork/patch/984163/
>>
>> For instance the TCAN device is a SPI device that uses a specific data payload to
>> determine writes and reads. In addition the device has a reset input as well
>> as a wakeup pin. The register offset of the m_can registers differs and must
>> be set by the device attached to the core.
>>
>> The m_can core will use iomapped writes and reads as the default mechanism for
>> writing and reading. The device driver can provide over rides for this.
>>
>> This patch series is not complete as it does not handle the CAN interrupts
>> nor can perform a CAN write. If this patch series is deemed acceptable I will
>> finish debugging the driver and post a non RFC series.
>>
>> Finally I did attempt to reduce the first patch with various git format patch
>> directives but none seemed to reduce the patch.
>>
>> Dan
>>
>> Dan Murphy (3):
>> can: m_can: Create m_can core to leverage common code
>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver
>> can: tcan4x5x: Add tcan4x5x driver to the kernel
>>
>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 +
>> drivers/net/can/m_can/Kconfig | 18 +
>> drivers/net/can/m_can/Makefile | 4 +-
>> drivers/net/can/m_can/m_can.c | 1683 +----------------
>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++--
>> drivers/net/can/m_can/m_can_core.h | 100 +
>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++
>> 7 files changed, 722 insertions(+), 1917 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%)
>> create mode 100644 drivers/net/can/m_can/m_can_core.h
>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c
>>
>
>
next prev parent reply other threads:[~2018-10-24 7:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 14:20 [RFC PATCH 0/3] M_CAN Framework rework Dan Murphy
2018-10-10 14:20 ` [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code Dan Murphy
2018-10-27 14:19 ` Wolfgang Grandegger
2018-10-31 20:15 ` Dan Murphy
2018-11-03 10:45 ` Wolfgang Grandegger
2018-11-09 15:14 ` Dan Murphy
2019-01-09 20:58 ` Dan Murphy
2019-01-10 7:44 ` Wolfgang Grandegger
2019-01-10 7:57 ` Rizvi, Mohammad Faiz Abbas
2019-01-10 12:54 ` Dan Murphy
2019-01-10 12:53 ` Dan Murphy
2019-01-11 8:27 ` Wolfgang Grandegger
2019-01-11 12:27 ` Dan Murphy
2018-10-10 14:20 ` [RFC PATCH 2/3] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2018-10-10 14:20 ` [RFC PATCH 3/3] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2018-10-17 20:21 ` [RFC PATCH 0/3] M_CAN Framework rework Dan Murphy
2018-10-24 7:33 ` Faiz Abbas
2018-10-24 11:39 ` Dan Murphy
2018-10-24 7:43 ` Wolfgang Grandegger [this message]
2018-10-24 11:36 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com \
--to=wg@grandegger.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).