From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89837C47094 for ; Thu, 10 Jun 2021 15:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62DE9613D8 for ; Thu, 10 Jun 2021 15:51:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231372AbhFJPxe (ORCPT ); Thu, 10 Jun 2021 11:53:34 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:43600 "EHLO mail-lj1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231772AbhFJPx1 (ORCPT ); Thu, 10 Jun 2021 11:53:27 -0400 Received: by mail-lj1-f180.google.com with SMTP id r14so5543033ljd.10; Thu, 10 Jun 2021 08:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dJEQ05qdu+8nKCCgzfIKNvAnjM3rPput3SGOoOdwVG4=; b=QXXfyC+CNRLr82a3T4zoVNqWsc6aHIooixWlBRMAvV8jgeq1VtCOLKgW9CnDdxXEMp bBSvfsLmLqGnvOfzibxr3DiX1hOtLD9chD2ojf8BYLPUkp6i8Z9AmDB2pv+a1emtFdh7 Es7D6Suy14DUN8O+jGAFcmXnGMIOSByWfW8ldXV8TLSLPxQffIyMQ+fnndbC7n27v4ze mmTuvG2gf/1dDU1KJgGpR8+vFs2nrjnaxtcvcfZ3VRfn1gUlEam3kl4AkxQhwynzRVCk G0yizUAc2LPeITpnC/C9x/6fZ5t8nPD+mtqluShpZqg8JGhG3G/FrZukLWvxjJAzjIrz 3jFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dJEQ05qdu+8nKCCgzfIKNvAnjM3rPput3SGOoOdwVG4=; b=TjjUKj+lYHFdek+ESe5L60iINFIoaqKlJkzX/foTOFLMZB5creRPgQ0IS8Jyzn04A7 J7yt9u3xZx6xOPrzYW8dX08hGct/Gx/qk9F4d3nAHqDSALMfiY+2uMw9FXUwMW6kytrV ROSjUSjFNIB/bOUbW2oXowDrrt3e3ZtIQHA8HeRCEg4mEOhLd0egsN8dk4A4rc3DQgKG E79WSjO9GOooIP2toAXXd84VqMhgaZ8bySZTwcRjXxqeBPcGP1/wKN7/TYRWcsmFQm11 7Uk/WvGf4zwz0PejBhuqo1h3OarAOGPwj42MZ0hLUVWGjzvC5l2uRb7XC4yKkOYxLJXd dd7w== X-Gm-Message-State: AOAM532qK3VfmN7sTBfqixqX6ssVX1FHfzB81/xYXWBeuhnC4do/v1Xj TTZ0OCK7rwg0bCRRgIKXrdbrG9wI1Ww= X-Google-Smtp-Source: ABdhPJwac9R6lTcA7YMbwSgbmVO2TftWIG8X61GWwb+P+TB9zUhcJYF8mm9KjWnbyK3VOGP+fv2uig== X-Received: by 2002:a2e:b4c9:: with SMTP id r9mr2805279ljm.306.1623340217082; Thu, 10 Jun 2021 08:50:17 -0700 (PDT) Received: from [192.168.2.145] (94-29-21-60.dynamic.spd-mgts.ru. [94.29.21.60]) by smtp.googlemail.com with ESMTPSA id z14sm380368ljc.51.2021.06.10.08.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 08:50:16 -0700 (PDT) Subject: Re: [PATCH 1/2] memory: tegra: Add missing dependencies To: Krzysztof Kozlowski , Thierry Reding , Philipp Zabel Cc: Jon Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210609112806.3565057-1-thierry.reding@gmail.com> <20210609112806.3565057-2-thierry.reding@gmail.com> <0c762772-929e-2eb8-6568-4aa82ea2f9ad@gmail.com> <1400979c-c7a7-9618-1168-70185ed10546@canonical.com> From: Dmitry Osipenko Message-ID: <8d8d019a-34c1-50bd-5eba-ce361c263d35@gmail.com> Date: Thu, 10 Jun 2021 18:50:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1400979c-c7a7-9618-1168-70185ed10546@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 10.06.2021 09:43, Krzysztof Kozlowski пишет: > The stubs might be good idea anyway, but the driver explicitly needs for > runtime working reservedmem, so it should select it. The OF and reservedmem are both selected by the ARCH for the runtime use. They may not be selected in the case of compile-testing. Both OF core and reservedmem provide stubs needed for compile-testing, it's only the RESERVEDMEM_OF_DECLARE() that is missing the stub. Adding the missing stub should be a more appropriate solution than adding extra Kconfig dependencies, IMO.