From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Joel Stanley" <joel@jms.id.au>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-clk@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 4/7] dt-bindings: clock: Add Nuvoton WPCM450 clock/reset controller
Date: Thu, 28 Apr 2022 11:23:26 +0200 [thread overview]
Message-ID: <8d919dc0-80a2-106f-9397-49263cf4ed5a@linaro.org> (raw)
In-Reply-To: <YmpWeOb3oetvqyvl@latitude>
On 28/04/2022 10:55, Jonathan Neuschäfer wrote:
>>>
>>> All these defines should be in second header in dt-bindings/reset/...
>>
>> I disagree. It makes more sense to keep the definitions together, and
>> it's all for the same hardware and driver.
These are bindings so the usage by same driver (Linux implementation)
matters less or even does not matter.
Driver can be split from one to several and you would need to include
clocks in your just-split-reset driver. Such driver split should not
affect bindings, therefore having the binding headers separate is
actually the most flexible.
>
> It's for the same hardware, DT node, and driver.
>
> I could imagine splitting it into
>
> include/dt-bindings/clock/nuvoton,wpcm450-clk.h and
> include/dt-bindings/reset/nuvoton,wpcm450-clk.h
>
> if someone insists on it.
>
> For convenience (being able to see all relevant definitions for
> nuvoton,wpcm450-clk at once), I'd prefer to keep the definitions together.
I don't insist. For some of the devices we split it, for some not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-28 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 18:30 [PATCH 0/7] Nuvoton WPCM450 clock and reset driver Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 1/7] dt-bindings: timer: nuvoton,npcm7xx-timer: Allow specifying all clocks Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 2/7] clocksource: timer-npcm7xx: Enable timer 1 clock before use Jonathan Neuschäfer
2022-04-28 9:11 ` Zev Weiss
2022-04-28 10:02 ` Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 3/7] watchdog: npcm: Enable clock if provided Jonathan Neuschäfer
2022-04-22 18:34 ` Guenter Roeck
2022-04-28 8:36 ` Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 4/7] dt-bindings: clock: Add Nuvoton WPCM450 clock/reset controller Jonathan Neuschäfer
2022-04-23 9:56 ` Krzysztof Kozlowski
2022-04-26 8:35 ` Joel Stanley
2022-04-28 8:55 ` Jonathan Neuschäfer
2022-04-28 9:23 ` Krzysztof Kozlowski [this message]
2022-04-28 8:48 ` Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 5/7] ARM: dts: wpcm450: Add clock controller node Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 6/7] clk: wpcm450: Add Nuvoton WPCM450 clock/reset controller driver Jonathan Neuschäfer
2022-04-22 18:30 ` [PATCH 7/7] ARM: dts: wpcm450: Switch clocks to clock controller Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d919dc0-80a2-106f-9397-49263cf4ed5a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wim@linux-watchdog.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).