From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932811AbdESVEQ (ORCPT ); Fri, 19 May 2017 17:04:16 -0400 Received: from terminus.zytor.com ([65.50.211.136]:36945 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932599AbdESVEO (ORCPT ); Fri, 19 May 2017 17:04:14 -0400 Subject: Re: [PATCH 7/7] DWARF: add the config option To: Josh Poimboeuf , linux-kernel@vger.kernel.org Cc: Jiri Slaby , Andrew Morton , live-patching@vger.kernel.org, Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Andy Lutomirski , Jiri Kosina , Linus Torvalds References: <20170505122200.31436-1-jslaby@suse.cz> <20170505122200.31436-7-jslaby@suse.cz> <20170507165524.cdxfuwbd5alr7v6k@treble> <20170519205354.caeyqri2k6gvso3w@treble> From: "H. Peter Anvin" Message-ID: <8dbbb971-fc41-fba2-f356-931a7eabe6ef@zytor.com> Date: Fri, 19 May 2017 13:59:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170519205354.caeyqri2k6gvso3w@treble> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/17 13:53, Josh Poimboeuf wrote: > > Here's the struct in its current state: > > #define UNDWARF_REG_UNDEFINED 0 > #define UNDWARF_REG_CFA 1 > #define UNDWARF_REG_SP 2 > #define UNDWARF_REG_FP 3 > #define UNDWARF_REG_SP_INDIRECT 4 > #define UNDWARF_REG_FP_INDIRECT 5 > #define UNDWARF_REG_R10 6 > #define UNDWARF_REG_DI 7 > #define UNDWARF_REG_DX 8 > Why only those registers? Also, if you have the option I would really suggest using the actual x86 register numbers (ax, ex, dx, bx, sp, bp, si, di, r8-r15 in that order.) -hpa