From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Joe Perches <joe@perches.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>
Subject: RE: [PATCH v2 00/10] fs: NTFS read-write driver GPL implementation by Paragon Software.
Date: Thu, 27 Aug 2020 16:12:45 +0000 [thread overview]
Message-ID: <8dc38559e18f43238e5b4cba533963cd@paragon-software.com> (raw)
In-Reply-To: <ed518871bf6182bb7d9a2b95074985cf8af1d5c4.camel@perches.com>
From: Joe Perches <joe@perches.com>
Sent: Friday, August 21, 2020 10:21 PM
>
> On Fri, 2020-08-21 at 16:24 +0000, Konstantin Komarov wrote:
> > This patch adds NTFS Read-Write driver to fs/ntfs3.
>
> Thanks.
> Proper ntfs read/write support will be great addition.
>
> Trivia:
>
> If this patchset is submitted again with a new version,
> please use something like "git format-patch --cover-letter"
> and "git send-email" so all parts of the patches and replies
> have the a single message thread to follow.
>
> That will add an "in-reply-to" header of the 0/m patch
> message-id to all n/m parts.
>
Hi Joe! Thanks a lot. Will use git send-email for V3. format-patch and --cover-letter have been already used for v2.
> One style oddity I noticed is the use of goto labels in
> favor of if block indentation. It's not terrible style,
> just unusual for kernel code.
>
AFAIK goto's are being quite widely used in kernel code as well. However V3 will introduce several goto's replacements with if blocks.
Thanks!
prev parent reply other threads:[~2020-08-27 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 16:24 [PATCH v2 00/10] fs: NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2020-08-21 19:21 ` Joe Perches
2020-08-27 16:12 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc38559e18f43238e5b4cba533963cd@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).