Re: [PATCH 7/7] irqchip/irq-mvebu-sei: Use devm_platform_ioremap_resource()

From: Marc Zyngier <marc.zyngier@arm.com>
To: Mukesh Ojha <mojha@codeaurora.org>,
	tglx@linutronix.de, jason@lakedaemon.net,
	yamada.masahiro@socionext.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] irqchip/irq-mvebu-sei: Use devm_platform_ioremap_resource()
Date: Mon, 29 Apr 2019 09:19:14 +0100	[thread overview]
Message-ID: <8dcac5eb-9ff6-1472-9aa1-6878ac5cb172@arm.com> (raw)
In-Reply-To: <1554362413-3305-8-git-send-email-mojha@codeaurora.org>

On 04/04/2019 08:20, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
> 
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
>  drivers/irqchip/irq-mvebu-sei.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c
> index 18832cc..0a09dcc 100644
> --- a/drivers/irqchip/irq-mvebu-sei.c
> +++ b/drivers/irqchip/irq-mvebu-sei.c
> @@ -382,8 +382,7 @@ static int mvebu_sei_probe(struct platform_device *pdev)
>  	mutex_init(&sei->cp_msi_lock);
>  	raw_spin_lock_init(&sei->mask_lock);
>  
> -	sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sei->base = devm_ioremap_resource(sei->dev, sei->res);
> +	sei->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sei->base)) {
>  		dev_err(sei->dev, "Failed to remap SEI resource\n");
>  		return PTR_ERR(sei->base);
> 

Again, what about sei->res?

	M.
-- 
Jazz is not dead. It just smells funny...