linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: alexandru.tachici@analog.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: robh+dt@kernel.org
Subject: Re: [PATCH v6 0/9] hwmon: pmbus: adm1266: add support
Date: Mon, 27 Jul 2020 07:10:10 -0700	[thread overview]
Message-ID: <8de28448-12a3-6d2e-14ab-299c57ff4391@roeck-us.net> (raw)
In-Reply-To: <20200727053121.23288-1-alexandru.tachici@analog.com>

On 7/26/20 10:31 PM, alexandru.tachici@analog.com wrote:
> From: Alexandru Tachici <alexandru.tachici@analog.com>
> 
> Add PMBus probing driver for the adm1266 Cascadable
> Super Sequencer with Margin Control and Fault Recording.
> Driver is using the pmbus_core, creating sysfs files
> under hwmon for inputs: vh1->vh4 and vp1->vp13.
> 

What happened to change logs ? Do you really expect me
to go through the history of this series to figure out
what changed from and in previous revisions of this
patch set ?

Guenter

> 1. Add PMBus probing driver for inputs vh1->vh4
> and vp1->vp13.
> 
> 2. Add Block Write-Read Process Call command.
> A PMBus specific implementation was required because
> block write with I2C_SMBUS_PROC_CALL flag allows a
> maximum of 32 bytes to be received.
> 
> 3. This makes adm1266 driver expose GPIOs
> to user-space. Currently are read only. Future
> developments on the firmware will allow
> them to be writable.
> 
> 4. Allow the current sate of the seqeuncer to be read
> through debugfs.
> 
> 5. Blackboxes are 64 bytes of chip state related data
> that is generated on faults. Use the nvmem kernel api
> to expose the blackbox chip functionality to userspace.
> 
> 6. Add group command support. This will allow the driver
> to stop/program all cascaded adm1266 devices at once.
> 
> 7. Writing the firmware hex file with offset 0
> to the nvmem of the master adm1266 will trigger
> the firmware programming of all cascaded devices.
> The master adm1266 of each device is specified in
> the devicetree.
> 
> 8. Writing the configuration hex file to 0x30000
> byte address of the nvmem file will trigger the
> programing of that device in particular.
> 
> 9. dt bindings for ADM1266.
> 
> Alexandru Tachici (9):
>   hwmon: pmbus: adm1266: add support
>   hwmon: pmbus: adm1266: Add Block process call
>   hwmon: pmbus: adm1266: Add support for GPIOs
>   hwmon: pmbus: adm1266: add debugfs for states
>   hwmon: pmbus: adm1266: read blackbox
>   hwmon: pmbus: adm1266: Add group command support
>   hwmon: pmbus: adm1266: program firmware
>   hwmon: pmbus: adm1266: program configuration
>   dt-bindings: hwmon: Add bindings for ADM1266
> 
>  .../bindings/hwmon/adi,adm1266.yaml           |   56 +
>  Documentation/hwmon/adm1266.rst               |   37 +
>  Documentation/hwmon/index.rst                 |    1 +
>  drivers/hwmon/pmbus/Kconfig                   |   10 +
>  drivers/hwmon/pmbus/Makefile                  |    1 +
>  drivers/hwmon/pmbus/adm1266.c                 | 1273 +++++++++++++++++
>  6 files changed, 1378 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
>  create mode 100644 Documentation/hwmon/adm1266.rst
>  create mode 100644 drivers/hwmon/pmbus/adm1266.c
> 


      parent reply	other threads:[~2020-07-27 14:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  5:31 [PATCH v6 0/9] hwmon: pmbus: adm1266: add support alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 1/9] " alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 2/9] hwmon: pmbus: adm1266: Add Block process call alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 3/9] hwmon: pmbus: adm1266: Add support for GPIOs alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 4/9] hwmon: pmbus: adm1266: add debugfs for states alexandru.tachici
2020-07-27  6:52   ` kernel test robot
2020-07-27  5:31 ` [PATCH v6 5/9] hwmon: pmbus: adm1266: read blackbox alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 6/9] hwmon: pmbus: adm1266: Add group command support alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 7/9] hwmon: pmbus: adm1266: program firmware alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 8/9] hwmon: pmbus: adm1266: program configuration alexandru.tachici
2020-07-27  5:31 ` [PATCH v6 9/9] dt-bindings: hwmon: Add bindings for ADM1266 alexandru.tachici
2020-07-27 14:10 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8de28448-12a3-6d2e-14ab-299c57ff4391@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexandru.tachici@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).