From: Sibi Sankar <firstname.lastname@example.org> To: Doug Anderson <email@example.com> Cc: Bjorn Andersson <firstname.lastname@example.org>, Rob Herring <email@example.com>, Andy Gross <firstname.lastname@example.org>, David Brown <email@example.com>, linux-arm-msm <firstname.lastname@example.org>, "open list:ARM/QUALCOMM SUPPORT" <email@example.com>, firstname.lastname@example.org, LKML <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Mark Rutland <email@example.com>, firstname.lastname@example.org, Evan Green <email@example.com>, Brian Norris <firstname.lastname@example.org> Subject: Re: [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5 Date: Tue, 18 Dec 2018 11:22:44 +0530 Message-ID: <email@example.com> (raw) In-Reply-To: <CAD=FV=Ui6ys4R3nenix3USeRPAd_vVdrArXxdf-iEc=4QRhE+A@mail.gmail.com> Hi Doug, Thanks for the review :) On 2018-12-18 05:29, Doug Anderson wrote: > Hi, > > On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar <firstname.lastname@example.org> > wrote: >> >> Add missing clock bindings for Q6V5 MSS on SDM845 SoCs. >> >> Signed-off-by: Sibi Sankar <email@example.com> >> --- >> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10 >> +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) > > Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc > on msm8996") > Fixes: fb22022ff63d ("dt-bindings: remoteproc: Add Q6v5 Modem PIL > binding for SDM845") > > ...it probably doesn't matter too much but if we wanted to be really > careful we could split into two patches, one for the msm8996 and one > for sdm845. I don't think people care that much about stable > backports of bindings though (someone can feel free to correct me)... > I did think of splitting this up but it doesn't actually fix 9f058fa2efb1 yet. I noticed a few missing clocks for mss on 8996 when I did a diff with the corresponding CAF tree. Hence couldn't add bindings for it. Will add them once I validate mss on 8996 with the necessary changes. > >> diff --git >> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> index 9ff5b0309417..780adc043b37 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> @@ -39,13 +39,17 @@ on the Qualcomm Hexagon core. >> - clocks: >> Usage: required >> Value type: <phandle> >> - Definition: reference to the iface, bus and mem clocks to be >> held on >> - behalf of the booting of the Hexagon core >> + Definition: reference to the list of 4 clocks for the modem >> sub-system >> + reference to the list of 8 clocks for the modem >> sub-system >> + on SDM845 SoCs > > The above is confusing because you don't list the SoCs that are > supposed to use the 4 clocks. How about instead: > > Definition: reference to the clocks that match clock-names > AFAIK, only the exceptions are captured. I am fine with both, I'll wait for Bjorn/Rob's preference. > >> - clock-names: >> Usage: required >> Value type: <stringlist> >> - Definition: must be "iface", "bus", "mem" >> + Definition: must be "iface", "bus", "mem", "xo" for the modem >> sub-system >> + must be "iface", "bus", "mem", "gpll0_mss", >> "snoc_axi", >> + "mnoc_axi", "prng", "xo" for the modem sub-system >> on SDM845 >> + SoCs > > Same here where it's confusing. ...but also, it it correct? As far > as I can tell you're missing msm8996. It's better to just be explicit > and list each one, ideally without all the prose. > > Definition: The clocks needed depend on the compatible string: > ditto > qcom,sdm845-mss-pil: "xo", "prng", "iface", "snoc_axi", "bus", "mem", > "gpll0_mss", "mnoc_axi" > qcom,msm8996-mss-pil: "xo", "pnoc", "iface", "bus", "mem", > "gpll0_mss_clk" ditto > qcom,msm8974-mss-pil: "xo", "iface", "bus", "mem" > qcom,msm8916-mss-pil: "xo", "iface", "bus", "mem" > qcom,q6v5-pil: "xo", "iface", "bus", "mem" > > ...as far as I can tell this binding is supposed to account for > "qcom,ipq8074-wcss-pil" too but it seems that one doesn't have > clock-names. > Yeah the lack of clocks have to be documented for ipq8074-wcss-pil.. will do it in v3 > > -Doug -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-17 10:07 [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Sibi Sankar 2018-12-17 10:07 ` [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5 Sibi Sankar 2018-12-17 23:59 ` Doug Anderson 2018-12-18 5:52 ` Sibi Sankar [this message] 2018-12-18 16:07 ` Doug Anderson 2018-12-18 17:27 ` Rob Herring 2018-12-19 7:04 ` Sibi Sankar 2018-12-17 10:07 ` [PATCH v2 3/7] dt-bindings: remoteproc: qcom: Fixup regulator dependencies Sibi Sankar 2018-12-18 0:00 ` Doug Anderson 2018-12-18 6:50 ` Sibi Sankar 2018-12-17 10:07 ` [PATCH v2 4/7] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 Sibi Sankar 2018-12-18 0:01 ` Doug Anderson 2018-12-18 6:30 ` Sibi Sankar 2018-12-17 10:07 ` [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar 2018-12-18 0:02 ` Doug Anderson 2018-12-18 6:35 ` Sibi Sankar 2018-12-18 16:00 ` kbuild test robot 2018-12-17 10:07 ` [PATCH v2 6/7] arm64: dts: qcom: sdm845: Add power-domain for " Sibi Sankar 2018-12-18 0:02 ` Doug Anderson 2018-12-18 6:38 ` Sibi Sankar 2018-12-17 10:07 ` [PATCH v2 7/7] arm64: dts: qcom: sdm845: Add shutdown-ack " Sibi Sankar 2018-12-18 0:02 ` Doug Anderson 2018-12-17 23:59 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Doug Anderson 2018-12-18 5:16 ` Sibi Sankar
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ firstname.lastname@example.org email@example.com public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox