* [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts()
@ 2021-01-05 9:22 Keqian Zhu
2021-01-05 10:08 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: Keqian Zhu @ 2021-01-05 9:22 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, kvm, kvmarm, Marc Zyngier,
Will Deacon, Mark Rutland, Catalin Marinas
Cc: Robin Murphy, Joerg Roedel, James Morse, Suzuki K Poulose,
Julien Thierry, wanghaibin.wang, Keqian Zhu
The local variable irq is added in commit a26388152531 ("arm64:
Remove custom IRQ stat accounting"), but forget to remove in
commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in
arch_show_interrupts()"). Just remove it.
Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
---
arch/arm64/kernel/smp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 6bc3a3698c3d..376343d6f13a 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -807,7 +807,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
unsigned int cpu, i;
for (i = 0; i < NR_IPI; i++) {
- unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
prec >= 4 ? " " : "");
for_each_online_cpu(cpu)
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts()
2021-01-05 9:22 [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() Keqian Zhu
@ 2021-01-05 10:08 ` Catalin Marinas
2021-01-05 10:48 ` Keqian Zhu
2021-01-05 11:09 ` Anshuman Khandual
0 siblings, 2 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-01-05 10:08 UTC (permalink / raw)
To: Keqian Zhu
Cc: linux-kernel, linux-arm-kernel, kvm, kvmarm, Marc Zyngier,
Will Deacon, Mark Rutland, Robin Murphy, Joerg Roedel,
James Morse, Suzuki K Poulose, Julien Thierry, wanghaibin.wang
On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote:
> The local variable irq is added in commit a26388152531 ("arm64:
> Remove custom IRQ stat accounting"), but forget to remove in
> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in
> arch_show_interrupts()"). Just remove it.
>
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
I already queued a similar fix in arm64 for-next/fixes (it should appear
in linux-next at some point).
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts()
2021-01-05 10:08 ` Catalin Marinas
@ 2021-01-05 10:48 ` Keqian Zhu
2021-01-05 11:09 ` Anshuman Khandual
1 sibling, 0 replies; 4+ messages in thread
From: Keqian Zhu @ 2021-01-05 10:48 UTC (permalink / raw)
To: Catalin Marinas
Cc: linux-kernel, linux-arm-kernel, kvm, kvmarm, Marc Zyngier,
Will Deacon, Mark Rutland, Robin Murphy, Joerg Roedel,
James Morse, Suzuki K Poulose, Julien Thierry, wanghaibin.wang
On 2021/1/5 18:08, Catalin Marinas wrote:
> On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote:
>> The local variable irq is added in commit a26388152531 ("arm64:
>> Remove custom IRQ stat accounting"), but forget to remove in
>> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in
>> arch_show_interrupts()"). Just remove it.
>>
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
>
> I already queued a similar fix in arm64 for-next/fixes (it should appear
> in linux-next at some point).
>
OK, I see. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts()
2021-01-05 10:08 ` Catalin Marinas
2021-01-05 10:48 ` Keqian Zhu
@ 2021-01-05 11:09 ` Anshuman Khandual
1 sibling, 0 replies; 4+ messages in thread
From: Anshuman Khandual @ 2021-01-05 11:09 UTC (permalink / raw)
To: Catalin Marinas, Keqian Zhu
Cc: Mark Rutland, kvm, Suzuki K Poulose, Marc Zyngier, Joerg Roedel,
linux-kernel, James Morse, Julien Thierry, wanghaibin.wang,
Will Deacon, kvmarm, linux-arm-kernel, Robin Murphy
On 1/5/21 3:38 PM, Catalin Marinas wrote:
> On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote:
>> The local variable irq is added in commit a26388152531 ("arm64:
>> Remove custom IRQ stat accounting"), but forget to remove in
>> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in
>> arch_show_interrupts()"). Just remove it.
>>
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
>
> I already queued a similar fix in arm64 for-next/fixes (it should appear
> in linux-next at some point)
I too sent this fix yesterday as well :) as it was preventing a clean
build on v5.11-rc2. Missed to check this on arm64 for-next/fixes though
I did check on linux-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-05 11:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 9:22 [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() Keqian Zhu
2021-01-05 10:08 ` Catalin Marinas
2021-01-05 10:48 ` Keqian Zhu
2021-01-05 11:09 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).