From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-hwmon@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/3] net: phy: add Broadcom BCM54140 support
Date: Fri, 17 Apr 2020 23:04:21 +0200 [thread overview]
Message-ID: <8e11a4792db1312b402d37a6a612cf8c@walle.cc> (raw)
In-Reply-To: <CA+h21hoB5n9DM0kcH_-DOzyxXvs5oMg-wxp-KkNTZOpfFhbWVA@mail.gmail.com>
Hi Vladimir,
Am 2020-04-17 22:00, schrieb Vladimir Oltean:
> Hi Michael,
>
> On Fri, 17 Apr 2020 at 22:52, Michael Walle <michael@walle.cc> wrote:
>>
>> Hi Andrew,
>>
>> Am 2020-04-17 21:39, schrieb Andrew Lunn:
>> > On Fri, Apr 17, 2020 at 09:28:57PM +0200, Michael Walle wrote:
>> >
>> >> +static int bcm54140_get_base_addr_and_port(struct phy_device *phydev)
>> >> +{
>> >> + struct bcm54140_phy_priv *priv = phydev->priv;
>> >> + struct mii_bus *bus = phydev->mdio.bus;
>> >> + int addr, min_addr, max_addr;
>> >> + int step = 1;
>> >> + u32 phy_id;
>> >> + int tmp;
>> >> +
>> >> + min_addr = phydev->mdio.addr;
>> >> + max_addr = phydev->mdio.addr;
>> >> + addr = phydev->mdio.addr;
>> >> +
>> >> + /* We scan forward and backwards and look for PHYs which have the
>> >> + * same phy_id like we do. Step 1 will scan forward, step 2
>> >> + * backwards. Once we are finished, we have a min_addr and
>> >> + * max_addr which resembles the range of PHY addresses of the same
>> >> + * type of PHY. There is one caveat; there may be many PHYs of
>> >> + * the same type, but we know that each PHY takes exactly 4
>> >> + * consecutive addresses. Therefore we can deduce our offset
>> >> + * to the base address of this quad PHY.
>> >> + */
>> >
>> > Hi Michael
>> >
>> > How much flexibility is there in setting the base address using
>> > strapping etc? Is it limited to a multiple of 4?
>>
>> You can just set the base address to any address. Then the following
>> addresses are used:
>> base, base + 1, base + 2, base + 3, (base + 4)*
>>
>> It is not specified what happens if you set the base so that it would
>> overflow. I guess that is a invalid strapping.
>>
>> * (base + 4) is some kind of special PHY address which maps some kind
>> of moving window to a QSGMII address space. It is enabled by default,
>> could be disabled in software, but it doesn't share the same PHY id
>> for which this scans.
>>
>> So yes, if you look at the addresses and the phy ids, there are
>> always 4 of this.
>>
>> -michael
>
> What does the reading of the global register give you, when accessed
> through the master PHY ID vs any other PHY ID? Could you use that as
> an indication of this being the correct PHY ID, and scan only to the
> left?
That was my first try, I thought it reads zero if you access a global
register by a PHY address which is not the base one. So I've looked
at registers which have at least one read-only 1 bit in it and scanned
only backwards. Well it turns out, my assumption was wrong and it
returns an old value of a successful read/write before. So it can just
return anything. And yes, its likely that you could read another
register and then probe the global register. But in the end I preferred
scanning the (known) phy id registers over strange hacks. Broadcom
could have just added a per-port register to actually read the base
address, but well.. ;)
-michael
next prev parent reply other threads:[~2020-04-17 21:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 19:28 [PATCH net-next 1/3] net: phy: broadcom: add helper to write/read RDB registers Michael Walle
2020-04-17 19:28 ` [PATCH net-next 2/3] net: phy: add Broadcom BCM54140 support Michael Walle
2020-04-17 19:39 ` Andrew Lunn
2020-04-17 19:50 ` Michael Walle
2020-04-17 20:00 ` Vladimir Oltean
2020-04-17 21:04 ` Michael Walle [this message]
2020-04-17 20:12 ` Andrew Lunn
2020-04-17 19:28 ` [PATCH net-next 3/3] net: phy: bcm54140: add hwmon support Michael Walle
2020-04-17 19:50 ` Andrew Lunn
2020-04-17 19:53 ` Michael Walle
2020-04-17 20:13 ` Andrew Lunn
2020-04-17 21:08 ` Michael Walle
2020-04-17 21:28 ` Andrew Lunn
2020-04-19 10:29 ` Michael Walle
2020-04-19 16:29 ` Andrew Lunn
2020-04-19 16:47 ` Michael Walle
2020-04-19 17:05 ` Andrew Lunn
2020-04-19 21:31 ` Michael Walle
2020-04-19 21:55 ` Andrew Lunn
2020-04-20 15:10 ` Michael Walle
2020-04-20 15:36 ` Andrew Lunn
2020-04-20 16:11 ` Michael Walle
2020-04-20 17:20 ` Russell King - ARM Linux admin
2020-04-19 17:12 ` Russell King - ARM Linux admin
2020-04-18 3:09 ` Guenter Roeck
2020-04-17 19:34 ` [PATCH net-next 1/3] net: phy: broadcom: add helper to write/read RDB registers Florian Fainelli
2020-04-18 14:13 ` Andrew Lunn
2020-04-18 15:55 ` Florian Fainelli
2020-04-18 20:09 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e11a4792db1312b402d37a6a612cf8c@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).