From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E87C48BCF for ; Thu, 10 Jun 2021 02:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C40F613E4 for ; Thu, 10 Jun 2021 02:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbhFJCsP (ORCPT ); Wed, 9 Jun 2021 22:48:15 -0400 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:53910 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229692AbhFJCsO (ORCPT ); Wed, 9 Jun 2021 22:48:14 -0400 Received: from omf10.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 707D552C0; Thu, 10 Jun 2021 02:46:18 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 7CD792351F5; Thu, 10 Jun 2021 02:46:17 +0000 (UTC) Message-ID: <8e163bf6c239ed519bbf754acac56f68897a3db3.camel@perches.com> Subject: Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign_str uses From: Joe Perches To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Jason Gunthorpe Date: Wed, 09 Jun 2021 19:46:16 -0700 In-Reply-To: <20210610010158.690158686@goodmis.org> References: <20210610010130.069460694@goodmis.org> <20210610010158.690158686@goodmis.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7CD792351F5 X-Stat-Signature: c4n9g831mrgc3citiquny67jmsg8gues X-Rspamd-Server: rspamout03 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+a/3s4biv8HcNs8D/V+E7llICJKv5cYH4= X-HE-Tag: 1623293177-605816 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-06-09 at 21:01 -0400, Steven Rostedt wrote: > From: Joe Perches > > The __assign_str macro has an unusual ending semicolon but the vast > majority of uses of the macro already have semicolon termination. > > $ git grep -P '\b__assign_str\b' | wc -l > 551 > $ git grep -P '\b__assign_str\b.*;' | wc -l > 480 > > Add semicolons to the __assign_str() uses without semicolon termination > and all the other uses without semicolon termination via additional defines > that are equivalent to __assign_str() with the eventual goal of removing > the semicolon from the __assign_str() macro definition. [] >  net/mac80211/trace.h | 2 +- [] > diff --git a/net/mac80211/trace.h b/net/mac80211/trace.h [] > @@ -33,7 +33,7 @@ >   __string(vif_name, sdata->name) >  #define VIF_ASSIGN __entry->vif_type = sdata->vif.type; __entry->sdata = sdata; \ >   __entry->p2p = sdata->vif.p2p; \ > - __assign_str(vif_name, sdata->name) > + __assign_str(vif_name, sdata->name); This one is unnecessary as every use of VIF_ASSIGN already has a semicolon termination.