From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbcFNQuf (ORCPT ); Tue, 14 Jun 2016 12:50:35 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:21522 "EHLO hkmmgate101.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751727AbcFNQuc (ORCPT ); Tue, 14 Jun 2016 12:50:32 -0400 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Tue, 14 Jun 2016 09:50:30 -0700 Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements To: Lee Jones References: <1463075104-26924-1-git-send-email-rklein@nvidia.com> <20160607080538.GG1525@dell> CC: Laxman Dewangan , , From: Rhyland Klein Message-ID: <8e25e615-e2db-ad9b-2aad-cc44599c58d1@nvidia.com> Date: Tue, 14 Jun 2016 12:50:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160607080538.GG1525@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/2016 4:05 AM, Lee Jones wrote: > On Thu, 12 May 2016, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, >> in the case of chip->chip_id == MAX77620, it will set >> fps_[mix|max]_period but then fall through to the default switch case >> and return -EINVAL. Returning this from max77620_config_fps() will >> cause probe to fail. >> >> Signed-off-by: Rhyland Klein >> --- >> drivers/mfd/max77620.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Applied to -fixes with Thierry and Laxman's Acks. > I don't see this in linux-next yet (as of 20160614). Can we get this merged there to. -rhyland -- nvpublic