From: Peter Rosin <peda@axentia.se>
To: Randy Dunlap <rdunlap@infradead.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mux: mmio: depend on REGMAP as the code has that dependency
Date: Sun, 11 Jun 2023 23:04:37 +0200 [thread overview]
Message-ID: <8e3176e3-8eb2-de7f-cc79-d04fe48ab8e6@axentia.se> (raw)
In-Reply-To: <fc94fa7f-2e73-7b9f-ea4c-2c5dffcbf844@infradead.org>
Hi!
2023-06-11 at 22:59, Randy Dunlap wrote:
> On 5/24/23 05:52, Peter Rosin wrote:
>> REGMAP is normally "selected", but that causes a recursive dependency.
>> But since REGMAP is "depended on" in other places, do so here as well.
>> The (implicit) REGMAP dependency was lost when the strict dependency
>> on MFD_SYSCON was removed.
*snip*
>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>> index 80f015cf6e54..7f07ca06eb2b 100644
>> --- a/drivers/mux/Kconfig
>> +++ b/drivers/mux/Kconfig
>> @@ -48,6 +48,7 @@ config MUX_GPIO
>> config MUX_MMIO
>> tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
>> depends on OF
>> + depends on REGMAP
>
> REGMAP is mostly selected, not depended on, so preferably
>
> select REGMAP
>
> here whenever this patch is ready to be merged.
I would have preferred that as well, and if that was without problems I
would not be so hesitant as there are really few pre-existing "depends
on REGMAP".
I do not know what to do here and am not sure whom to ask for guidance.
Cheers,
Peter
next prev parent reply other threads:[~2023-06-11 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 3:34 mux/mmio: randconfig build errors Randy Dunlap
2023-02-10 10:41 ` Peter Rosin
2023-02-10 10:46 ` [PATCH] mux: mmio: select REGMAP as the code has that dependency Peter Rosin
2023-02-10 11:56 ` Philipp Zabel
2023-05-24 12:49 ` Peter Rosin
2023-05-24 12:52 ` [PATCH v2] mux: mmio: depend on " Peter Rosin
2023-06-11 20:59 ` Randy Dunlap
2023-06-11 21:04 ` Peter Rosin [this message]
2023-06-11 21:13 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3176e3-8eb2-de7f-cc79-d04fe48ab8e6@axentia.se \
--to=peda@axentia.se \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).