* [PATCH] block/bfq: remove unused bfq_class_rt which never used
@ 2020-01-21 8:48 Alex Shi
2020-01-22 17:31 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2020-01-21 8:48 UTC (permalink / raw)
Cc: Paolo Valente, Jens Axboe, linux-block, linux-kernel
This macro is never used after introduced from commit aee69d78dec0
("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")
Better to remove it.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
block/bfq-iosched.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index ad4af4aaf2ce..4686b68b48b4 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -427,7 +427,6 @@ void bfq_schedule_dispatch(struct bfq_data *bfqd)
}
#define bfq_class_idle(bfqq) ((bfqq)->ioprio_class == IOPRIO_CLASS_IDLE)
-#define bfq_class_rt(bfqq) ((bfqq)->ioprio_class == IOPRIO_CLASS_RT)
#define bfq_sample_valid(samples) ((samples) > 80)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block/bfq: remove unused bfq_class_rt which never used
2020-01-21 8:48 [PATCH] block/bfq: remove unused bfq_class_rt which never used Alex Shi
@ 2020-01-22 17:31 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-01-22 17:31 UTC (permalink / raw)
To: Alex Shi; +Cc: Paolo Valente, linux-block, linux-kernel
On 1/21/20 1:48 AM, Alex Shi wrote:
> This macro is never used after introduced from commit aee69d78dec0
> ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")
>
> Better to remove it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 8:48 [PATCH] block/bfq: remove unused bfq_class_rt which never used Alex Shi
2020-01-22 17:31 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).