linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	Bart Van Assche <bvanassche@acm.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] workqueue: Add back __printf format validation
Date: Wed, 02 Jun 2021 20:11:48 -0700	[thread overview]
Message-ID: <8e60e269d4fe74af767baee1b3048dda6ac17e05.camel@perches.com> (raw)

commit 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for
workqueues") indirectly removed the printf validation for alloc_workqueue.

Add it back.

Signed-off-by: Joe Perches <joe@perches.com>
---

compiled x86-64 defconfig only, but there _might_ be some new
warning for a fmt/arg mismatch somewhere.  Hope not...

 include/linux/workqueue.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index d15a7730ee18b..7c177267a81f3 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -404,6 +404,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
  * RETURNS:
  * Pointer to the allocated workqueue on success, %NULL on failure.
  */
+__printf(1, 4)
 struct workqueue_struct *alloc_workqueue(const char *fmt,
 					 unsigned int flags,
 					 int max_active, ...);



             reply	other threads:[~2021-06-03  3:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  3:11 Joe Perches [this message]
2021-06-04 14:55 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e60e269d4fe74af767baee1b3048dda6ac17e05.camel@perches.com \
    --to=joe@perches.com \
    --cc=bvanassche@acm.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --subject='Re: [PATCH] workqueue: Add back __printf format validation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox