From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peron.clem@gmail.com" <peron.clem@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
"David Woodhouse" <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v3] mtd: spinand: Fix ECC status and OOB layout for Toshiba TC58CVG2S0H
Date: Fri, 7 Dec 2018 09:31:47 +0000 [thread overview]
Message-ID: <8e70737f-0780-d607-eadc-f6435288f660@kontron.de> (raw)
In-Reply-To: <20181207090041.6b8d9731@xps13>
Hi Miquèl,
On 07.12.18 09:00, Miquel Raynal wrote:
> Hi Schrempf, Clément,
>
> Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Mon, 3 Dec 2018
> 08:01:38 +0000:
>
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> When reading the status of the on-chip ECC, the Toshiba chip returns
>> two different states for reporting corrected bitflips. We should check
>> for both of them.
>>
>> Also return the free OOB bytes as one contiguous area, instead of
>> multiple sections.
>>
>> Suggested-by: Clément Péron <peron.clem@gmail.com>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> Acked-by: Clément Péron <peron.clem@gmail.com>
>> ---
>> Changes for v3:
>> ===============
>> * Add Acked-by
>> * Add comment for BBM in OOB layout
>>
>> Changes for v2:
>> ===============
>> * Remove the changes to the ECC bytes in the OOB layout
>> ---
>> drivers/mtd/nand/spi/toshiba.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c
>> index 294bcf6..0812655 100644
>> --- a/drivers/mtd/nand/spi/toshiba.c
>> +++ b/drivers/mtd/nand/spi/toshiba.c
>> @@ -11,6 +11,7 @@
>> #include <linux/mtd/spinand.h>
>>
>> #define SPINAND_MFR_TOSHIBA 0x98
>> +#define TOSH_STATUS_ECC_HAS_BITFLIPS_T (3 << 4)
>>
>> static SPINAND_OP_VARIANTS(read_cache_variants,
>> SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
>> @@ -33,19 +34,18 @@ static int tc58cvg2s0h_ooblayout_ecc(struct mtd_info *mtd, int section,
>> region->offset = 128 + 16 * section;
>> region->length = 16;
>>
>> -
>> return 0;
>> }
>>
>> static int tc58cvg2s0h_ooblayout_free(struct mtd_info *mtd, int section,
>> struct mtd_oob_region *region)
>> {
>> - if (section > 7)
>> + if (section > 0)
>> return -ERANGE;
>>
>> - region->offset = 2 + 16 * section;
>> - region->length = 14;
>> -
>> + /* 2 bytes reserved for BBM */
>> + region->offset = 2;
>> + region->length = 126;
>>
>> return 0;
>> }
>> @@ -70,6 +70,7 @@ static int tc58cvg2s0h_ecc_get_status(struct spinand_device *spinand,
>> return -EBADMSG;
>>
>> case STATUS_ECC_HAS_BITFLIPS:
>> + case TOSH_STATUS_ECC_HAS_BITFLIPS_T:
>> /*
>> * Let's try to retrieve the real maximum number of bitflips
>> * in order to avoid forcing the wear-leveling layer to move
>
> If you don't mind, I would like to squash this with the original patch.
> What about also adding Clement's Acked-by to it?
Sure, you can squash this with the original patch. And I guess adding
Clément's Acked-by would be appropriate, too.
Thanks,
Frieder
next prev parent reply other threads:[~2018-12-07 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 8:01 [PATCH v3] mtd: spinand: Fix ECC status and OOB layout for Toshiba TC58CVG2S0H Schrempf Frieder
2018-12-07 8:00 ` Miquel Raynal
2018-12-07 9:31 ` Schrempf Frieder [this message]
2018-12-07 9:39 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e70737f-0780-d607-eadc-f6435288f660@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=peron.clem@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).