linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Takata <takatan.linux@gmail.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, doubt@developer.osdl.jp
Subject: [PATCH] enable XFS write barrier
Date: Mon, 23 Jan 2006 23:40:28 +0900	[thread overview]
Message-ID: <8e8498350601230640x49d8f866q@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

I found out that the q->ordered is not being set properly on XFS.


I'm testing the write barrier support of XFS.
I run the test on kernel 2.6.16-rc1-git4.
but I found out that the "-o barrier" option is automatically disabled
in my environment.
For this reason I could not test the write barrier's execution path.

The error message in "/var/log/messages" is:
Filesystem "sdb1": Disabling barriers, not supported by the underlying device


This patch fixes these bugs.


Best regards,

Tetsuo Takata

[-- Attachment #2: 2.6.16-rc1-git4-sd.patch --]
[-- Type: application/octet-stream, Size: 559 bytes --]

The patch below fixes the aforementioned problem.

Signed-off-by: Tetsuo Takata <takatatt@intellilink.co.jp>
---

diff -urpN linux-2.6.16-rc1-git4/block/ll_rw_blk.c linux-2.6.16-rc1-git4-fixed/block/ll_rw_blk.c
--- linux-2.6.16-rc1-git4/block/ll_rw_blk.c	2006-01-23 21:29:12.000000000 +0900
+++ linux-2.6.16-rc1-git4-fixed/block/ll_rw_blk.c	2006-01-23 22:05:11.000000000 +0900
@@ -332,6 +332,7 @@ int blk_queue_ordered(request_queue_t *q
 		return -EINVAL;
 	}
 
+	q->ordered = ordered;
 	q->next_ordered = ordered;
 	q->prepare_flush_fn = prepare_flush_fn;


             reply	other threads:[~2006-01-23 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 14:40 Tetsuo Takata [this message]
2006-01-23 14:48 ` [PATCH] enable XFS write barrier Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8498350601230640x49d8f866q@mail.gmail.com \
    --to=takatan.linux@gmail.com \
    --cc=akpm@osdl.org \
    --cc=doubt@developer.osdl.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).