From: Shuah Khan <skhan@linuxfoundation.org>
To: Denys Vlasenko <dvlasenk@redhat.com>, linux-kernel@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install
Date: Mon, 31 Aug 2020 14:49:50 -0600 [thread overview]
Message-ID: <8ea61655-c4b3-0fa9-ec70-b63adbbe5c84@linuxfoundation.org> (raw)
In-Reply-To: <20200817150946.21477-1-dvlasenk@redhat.com>
On 8/17/20 9:09 AM, Denys Vlasenko wrote:
> If top make invocation uses -j4 or larger, this patch reduces
> "make headers_install" subtask run time from 30 to 7 seconds.
>
> CC: Shuah Khan <shuah@kernel.org>
> CC: Shuah Khan <skhan@linuxfoundation.org>
> CC: linux-kselftest@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> ---
> tools/testing/selftests/lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7a17ea815736..51124b962d56 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -47,9 +47,9 @@ ARCH ?= $(SUBARCH)
> khdr:
> ifndef KSFT_KHDR_INSTALL_DONE
> ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
> - make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
> + $(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
> else
> - make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
> + $(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
> ARCH=$(ARCH) -C $(top_srcdir) headers_install
> endif
> endif
>
Thanks for the patch. Applied to linux-kselftest next for 5.10
thanks,
-- Shuah
prev parent reply other threads:[~2020-08-31 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 15:09 [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install Denys Vlasenko
2020-08-31 20:49 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea61655-c4b3-0fa9-ec70-b63adbbe5c84@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).