From: Jon Hunter <jonathanh@nvidia.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
<linux-i2c@vger.kernel.org>
Cc: <linux-renesas-soc@vger.kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/12] i2c: tegra: use core to detect 'no zero length' quirk
Date: Fri, 5 Oct 2018 14:52:05 +0100 [thread overview]
Message-ID: <8eb3d00b-0275-30ec-ef44-5e859dd9242f@nvidia.com> (raw)
In-Reply-To: <20180723202617.15230-9-wsa+renesas@sang-engineering.com>
On 23/07/18 21:26, Wolfram Sang wrote:
> And don't reimplement in the driver.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Only build tested.
>
> drivers/i2c/busses/i2c-tegra.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 60c8561fbe65..437294ea2f0a 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -684,9 +684,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>
> tegra_i2c_flush_fifos(i2c_dev);
>
> - if (msg->len == 0)
> - return -EINVAL;
> -
> i2c_dev->msg_buf = msg->buf;
> i2c_dev->msg_buf_remaining = msg->len;
> i2c_dev->msg_err = I2C_ERR_NONE;
> @@ -831,6 +828,7 @@ static const struct i2c_algorithm tegra_i2c_algo = {
>
> /* payload size is only 12 bit */
> static const struct i2c_adapter_quirks tegra_i2c_quirks = {
> + .flags = I2C_AQ_NO_ZERO_LEN,
> .max_read_len = 4096,
> .max_write_len = 4096,
> };
Sorry for missing this, but looks fine to me, so ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2018-10-05 13:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 20:26 [PATCH 00/12] i2c: quirks: add zero length checks and update drivers Wolfram Sang
2018-07-23 20:26 ` [PATCH 01/12] i2c: quirks: add zero length checks Wolfram Sang
2018-07-23 20:44 ` Niklas Söderlund
2018-07-23 21:05 ` Wolfram Sang
2018-08-04 21:26 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 02/12] i2c: designware-master: use core to detect 'no zero length' quirk Wolfram Sang
2018-08-02 14:00 ` Jarkko Nikula
2018-08-04 21:26 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 03/12] i2c: mxs: " Wolfram Sang
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 04/12] i2c: omap: " Wolfram Sang
2018-10-05 12:24 ` Wolfram Sang
2018-10-05 14:11 ` Grygorii Strashko
2018-10-05 14:30 ` Tony Lindgren
2018-10-05 16:07 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 05/12] i2c: pmcmsp: " Wolfram Sang
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 06/12] i2c: qup: " Wolfram Sang
2018-10-05 12:24 ` Wolfram Sang
2018-10-05 14:23 ` Andy Gross
2018-10-05 16:07 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 07/12] i2c: stu300: " Wolfram Sang
2018-07-25 20:52 ` Linus Walleij
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 08/12] i2c: tegra: " Wolfram Sang
2018-10-05 12:24 ` Wolfram Sang
2018-10-05 13:52 ` Jon Hunter [this message]
2018-10-05 16:08 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 09/12] i2c: zx2967: " Wolfram Sang
2018-10-05 12:24 ` Wolfram Sang
2018-10-05 13:04 ` Shawn Guo
2018-10-05 16:08 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 10/12] i2c: rcar: " Wolfram Sang
2018-07-23 20:46 ` Niklas Söderlund
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 11/12] i2c: xlr: " Wolfram Sang
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:26 ` [PATCH 12/12] i2c: sh_mobile: use core to detect 'no zero length read' quirk Wolfram Sang
2018-07-23 20:54 ` Niklas Söderlund
2018-08-04 21:27 ` Wolfram Sang
2018-07-23 20:47 ` [PATCH 00/12] i2c: quirks: add zero length checks and update drivers Andy Shevchenko
2018-08-04 21:26 ` Wolfram Sang
2018-08-04 21:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb3d00b-0275-30ec-ef44-5e859dd9242f@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).