From: Dave Hansen <dave.hansen@intel.com>
To: Qian Cai <cai@lca.pw>, Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ben.widawsky@intel.com, alex.shi@linux.alibaba.com,
dwagner@suse.de, tobin@kernel.org, cl@linux.com,
akpm@linux-foundation.org, stable@kernel.org
Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI
Date: Fri, 26 Jun 2020 14:24:31 -0700 [thread overview]
Message-ID: <8ed92030-9dab-2f86-f30d-8c9357083e42@intel.com> (raw)
In-Reply-To: <20200626192426.GA4329@lca.pw>
On 6/26/20 12:24 PM, Qian Cai wrote:
>> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
>> Fixes: commit 648b5cf368e0 ("mm/vmscan: remove unused RECLAIM_OFF/RECLAIM_ZONE")
> This is a wrong format.
The Fixes: line? Yeah, I think checkpatch was complaing about a
reference to a commit in the main changelog, and it suggested prefixing
the sha1 with "commit". I misinterpreted that warning to mean the
"Fixes:" line instead of the changelog.
I'll fix it up in v2.
next prev parent reply other threads:[~2020-06-26 21:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 0:34 [PATCH] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-06-26 7:59 ` Daniel Wagner
2020-06-26 13:53 ` Dave Hansen
2020-06-29 7:13 ` Daniel Wagner
2020-06-29 14:36 ` Dave Hansen
2020-06-29 15:53 ` Daniel Wagner
2020-06-29 16:05 ` Dave Hansen
2020-06-26 19:24 ` Qian Cai
2020-06-26 21:24 ` Dave Hansen [this message]
2020-06-29 6:52 ` Baoquan He
2020-06-29 14:27 ` Dave Hansen
2020-06-29 23:30 ` Baoquan He
2020-06-29 23:37 ` Dave Hansen
2020-07-01 2:47 ` Andrew Morton
2020-07-01 15:27 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed92030-9dab-2f86-f30d-8c9357083e42@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@kernel.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).