Re: [PATCH v2 1/8] ASoC: amd: Add common framework to support I2S on ACP SOC

[Randy Dunlap <rdunlap@infradead.org>]

On 10/11/21 8:44 AM, Ajit Kumar Pandey wrote:
> We are using legacy way of exposing dais and DMA configuration that
> requires separate driver modules for various ACP SOC with almost
> similar hw configuration. Moreover the legacy approach requires
> separate I2S and DMA module platform devices registration and need
> machine specific quirk to control various I2S endpoints. Add generic
> dai driver and platform driver for I2S controller on ACP hw block.
> This common framework can be used by various ACP platform devices
> that shares common specs.
> 
> Signed-off-by: Ajit Kumar Pandey<AjitKumar.Pandey@amd.com>
> ---

> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
> new file mode 100644
> index 000000000000..6b993074e2c4
> --- /dev/null
> +++ b/sound/soc/amd/acp/Kconfig
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
> +# This file is provided under a dual BSD/GPLv2 license. When using or
> +# redistributing this file, you may do so under either license.
> +#
> +# Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
> +#
> +
> +config SND_SOC_AMD_ACP_COMMON
> +	tristate "AMD Audio ACP Common support"
> +	select SND_AMD_ACP_CONFIG
> +	help
> +	  This option enables ACP support on AMD platform.
> +
> +config SND_SOC_AMD_ACP_I2S
> +	tristate
> +
> +config SND_SOC_AMD_ACP_PCM
> +	tristate

Hi,
I don't see anything that tells us what "ACP" is.
Please add that somewhere -- either in the Kconfig file or
at least in the commit description.

thanks.

-- 
~Randy