From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: William Kucharski <william.kucharski@oracle.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: (No subject)
Date: Tue, 28 Dec 2021 09:36:53 +0800 [thread overview]
Message-ID: <8f30057e-da61-55b4-adf7-e35d91798806@huawei.com> (raw)
In-Reply-To: <E2C9DE8E-F5D9-46E9-9298-B632A202B080@oracle.com>
On 2021/12/28 1:35, William Kucharski wrote:
> You should also fix the existing typo in the documentation (inline):
>
>> On Dec 27, 2021, at 07:49, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
>> This patch select HAVE_ARCH_HUGE_VMALLOC to let arm64 support huge
>> vmalloc mappings.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> Documentation/admin-guide/kernel-parameters.txt | 4 ++--
>> arch/arm64/Kconfig | 1 +
>> arch/arm64/kernel/module.c | 5 +++--
>> 3 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index 7b2f900fd243..e3f9fd7ec106 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -1639,7 +1639,7 @@
>> precedence over memory_hotplug.memmap_on_memory.
>>
>>
>> - hugevmalloc= [PPC] Reguires CONFIG_HAVE_ARCH_HUGE_VMALLOC
>> + hugevmalloc= [KNL,PPC,ARM64] Reguires CONFIG_HAVE_ARCH_HUGE_VMALLOC
>> Format: { on | off }
>> Default set by CONFIG_HUGE_VMALLOC_DEFAULT_ENABLED.
> "Reguires" should be "Requires."
Will fix, thanks.
>
>> @@ -3424,7 +3424,7 @@
>>
>> nohugeiomap [KNL,X86,PPC,ARM64] Disable kernel huge I/O mappings.
>>
>> - nohugevmalloc [PPC] Disable kernel huge vmalloc mappings.
>> + nohugevmalloc [KNL,PPC,ARM64] Disable kernel huge vmalloc mappings.
>>
>> nosmt [KNL,S390] Disable symmetric multithreading (SMT).
>> Equivalent to smt=1.
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 3bb0b67292b5..c34bbb4482b0 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -142,6 +142,7 @@ config ARM64
>> select HAVE_ARCH_AUDITSYSCALL
>> select HAVE_ARCH_BITREVERSE
>> select HAVE_ARCH_COMPILER_H
>> + select HAVE_ARCH_HUGE_VMALLOC
>> select HAVE_ARCH_HUGE_VMAP
>> select HAVE_ARCH_JUMP_LABEL
>> select HAVE_ARCH_JUMP_LABEL_RELATIVE
>> diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c
>> index 309a27553c87..af7b4cbace2b 100644
>> --- a/arch/arm64/kernel/module.c
>> +++ b/arch/arm64/kernel/module.c
>> @@ -36,7 +36,8 @@ void *module_alloc(unsigned long size)
>> module_alloc_end = MODULES_END;
>>
>> p = __vmalloc_node_range(size, MODULE_ALIGN, module_alloc_base,
>> - module_alloc_end, gfp_mask, PAGE_KERNEL, VM_DEFER_KMEMLEAK,
>> + module_alloc_end, gfp_mask, PAGE_KERNEL,
>> + VM_DEFER_KMEMLEAK | VM_NO_HUGE_VMAP,
>> NUMA_NO_NODE, __builtin_return_address(0));
>>
>> if (!p && IS_ENABLED(CONFIG_ARM64_MODULE_PLTS) &&
>> @@ -55,7 +56,7 @@ void *module_alloc(unsigned long size)
>> */
>> p = __vmalloc_node_range(size, MODULE_ALIGN, module_alloc_base,
>> module_alloc_base + SZ_2G, GFP_KERNEL,
>> - PAGE_KERNEL, 0, NUMA_NO_NODE,
>> + PAGE_KERNEL, VM_NO_HUGE_VMAP, NUMA_NO_NODE,
>> __builtin_return_address(0));
>>
>> if (p && (kasan_module_alloc(p, size, gfp_mask) < 0)) {
>> --
>> 2.26.2
>>
>>
next prev parent reply other threads:[~2021-12-28 1:37 UTC|newest]
Thread overview: 145+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 14:59 [PATCH v2 0/3] mm: support huge vmalloc mapping on arm64/x86 Kefeng Wang
2021-12-27 14:59 ` [PATCH v2 1/3] mm: vmalloc: Let user to control huge vmalloc default behavior Kefeng Wang
2022-01-18 2:52 ` Nicholas Piggin
2022-01-19 12:57 ` Kefeng Wang
2022-01-19 13:22 ` Matthew Wilcox
2022-01-19 13:44 ` Kefeng Wang
2022-01-19 13:48 ` Matthew Wilcox
2021-12-27 14:59 ` [PATCH v2 2/3] arm64: Support huge vmalloc mappings Kefeng Wang
2021-12-27 17:35 ` (No subject) William Kucharski
2021-12-28 1:36 ` Kefeng Wang [this message]
2022-01-15 10:05 ` [PATCH v2 2/3] arm64: Support huge vmalloc mappings Christophe Leroy
2021-12-27 14:59 ` [PATCH v2 3/3] x86: " Kefeng Wang
2021-12-27 15:56 ` Dave Hansen
2021-12-28 10:26 ` Kefeng Wang
2021-12-28 16:14 ` Dave Hansen
2021-12-29 11:01 ` Kefeng Wang
2022-01-15 10:17 ` Christophe Leroy
2022-01-15 10:15 ` Christophe Leroy
2022-01-18 2:46 ` Nicholas Piggin
2022-01-18 17:28 ` Dave Hansen
2022-01-19 4:17 ` Nicholas Piggin
2022-01-19 13:32 ` Kefeng Wang
2022-01-15 10:11 ` Christophe Leroy
2022-01-15 10:06 ` Christophe Leroy
2022-01-15 10:07 ` [PATCH v2 0/3] mm: support huge vmalloc mapping on arm64/x86 Christophe Leroy
-- strict thread matches above, loose matches on Subject: below --
2024-01-31 3:37 (No Subject) John Moon
2023-08-31 4:52 youngbludproductions
2023-08-31 5:11 ` youngbludproductions
2023-05-13 8:12 [no subject] Beatrice Benson
2021-06-22 16:20 (No Subject) Yassine Oudjana
2021-07-14 18:03 ` Rob Herring
2019-05-22 2:09 [No Subject] Gardner, Tim
2015-08-07 6:30 (no subject) Mr. Vincent Cheng
2015-07-29 21:56 Mr. Vincent Cheng
2014-09-20 22:12 Cleveland Finance
2014-09-03 12:19 US-ARMEE
2014-05-03 16:50 James McCammond
2013-11-23 2:09 SANTANDER ASSET FINANCE PLC
2012-10-12 13:00 a1tmblwd
2012-09-19 14:53 Webmaster
2012-04-09 14:39 niamathullah sharief
2011-06-04 9:21 ©2011.Coca-Cola Great Britain
2011-05-25 18:36 ©2011.Coca-Cola Great Britain
2010-06-14 20:26 [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages Justin P. Mattock
2010-06-14 20:26 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Justin P. Mattock
2010-06-14 21:44 ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-14 22:35 ` Justin P. Mattock
2010-06-14 23:22 ` Stefan Richter
2010-06-15 0:08 ` (no subject) Stefan Richter
2009-12-14 23:44 Mr Mou Xinsheng
2009-08-24 19:35 MRS SANDRA WHITE
2009-08-23 17:49 INFO
2009-08-03 10:14 kell
2009-07-17 12:02 UK
2009-07-17 4:17 CG LOTTO
2009-07-13 23:56 Camelot Group.
2009-07-10 21:36 The UKNL
2009-07-09 7:20 UKNL
2009-07-09 2:20 UKNL
2009-07-02 14:23 The British
2009-06-30 1:16 Mrs Dianne Thompson
2009-06-29 19:56 Uknl
2009-06-23 16:08 UNL
2009-06-23 2:55 UKL-DEPT
2009-06-21 13:34 The Nat
2009-06-09 18:04 IL
2009-05-29 13:14 Camelot Uk
2009-05-28 4:26 CL
2009-05-28 1:44 Cgnlwin
2009-05-26 18:10 Mnl
2009-05-25 18:02 IL
2009-05-23 18:14 Cgnlwin
2009-05-23 11:09 Mnl
2009-05-18 15:12 Mnl
2009-05-18 12:16 Mnl
2009-05-18 9:59 Mnl
2009-05-18 8:58 Mnl
2009-05-16 4:56 il
2009-05-15 14:29 il
2009-05-09 1:50 IL
2008-04-06 12:47 [PATCH] x86: remove superfluous initialisation in boot code Alexander van Heukelum
2008-04-07 7:46 ` Ingo Molnar
2008-04-07 9:13 ` Alexander van Heukelum
2008-04-07 10:00 ` (no subject) zhenwenxu
2008-02-01 18:14 veerasena reddy
2008-02-04 5:41 ` (no subject) Ramgopal Kota
2007-09-07 22:19 Jim Cromie
2007-06-08 7:53 Nicklas Bondesson
2007-02-15 11:54 ddup1
2007-02-01 9:19 ddup1
2007-01-26 7:29 orig
2007-01-25 20:50 Craig Van Tassle
2006-09-16 9:11 Laurent CARON
2006-09-16 9:10 Laurent CARON
2006-08-03 8:25 Franck Bui-Huu
2006-06-05 19:48 process starvation with 2.6 scheduler Kallol Biswas
2006-06-05 23:49 ` (no subject) Hack Sung Lee
2006-05-14 12:57 [No Subject] Arnulfo Titor
2006-01-07 4:16 (no subject) Chaitanya Vinay Hazarey
2005-11-30 5:56 [GIT PATCH] USB patches for 2.6.15-rc3 Greg KH
2005-11-30 18:23 ` Linus Torvalds
2005-11-30 19:35 ` Greg KH
2005-12-01 4:10 ` (no subject) Glenn L Shurson
2005-11-18 16:05 Andi Kleen
2005-11-21 10:06 ` (no subject) Keir Fraser
2005-11-21 10:11 ` Russell King
2005-11-21 17:27 ` Andi Kleen
2005-05-22 16:05 Pedro Henrique
2005-05-22 12:40 Timo Hallek
2005-05-18 7:56 suzuki
2005-04-26 4:20 Frederic Weisbecker
2005-03-29 4:46 Sumesh
2005-03-10 2:03 Ray Bryant
2005-02-16 4:08 Ethan Weinstein
2005-01-20 19:33 Ram Kumar
2004-10-27 12:09 Mirko Bonasorte
2004-09-01 2:42 Anthony DiSante
2004-08-29 13:21 <no subject> Joachim Bremer
2004-08-29 12:36 Joachim Bremer
2004-08-29 12:42 ` Nick Piggin
2004-08-16 1:09 (no subject) A. Mani
2004-06-30 17:58 Frederic Krueger
2004-06-30 9:50 <no subject> Michael Tasche
2004-03-18 1:08 True fsync() in Linux (on IDE) Peter Zaitsev
2004-03-18 6:47 ` Jens Axboe
2004-03-18 11:34 ` Matthias Andree
2004-03-18 11:58 ` (no subject) Daniel Czarnecki
2004-02-25 15:16 Joel Cant
2004-02-25 15:54 ` Redeeman
[not found] <402A710F.9080908@surricani.cjb.net>
2004-02-11 18:20 ` Armen Kaleshian
2004-02-09 21:05 Alexandr Chernyy
2004-02-09 21:22 ` Matti Aarnio
2004-02-09 22:46 ` Alessandro Amici
2003-12-05 23:35 Jonathan Fors
2003-11-04 15:47 Bas van Kampen
2003-11-02 21:58 phil
2003-09-01 6:15 Honne Gowda A
2003-09-01 12:46 ` Herbert Poetzl
2003-08-13 9:14 Vid Strpic
2003-08-13 10:36 ` Catalin BOIE
2003-08-13 11:34 ` Herbert Pötzl
2003-08-07 1:46 (No Subject) Solaris Wildchild
2003-07-20 11:46 (no subject) Cédric Barboiron
2003-07-20 19:43 ` jiho
2003-05-20 10:50 COMALP - Mar.Ord. MATTIUZZO Riccardo
2003-05-16 21:35 Anders Franzen
2003-03-19 3:21 Gabe Arnold
2003-03-16 15:35 MaxF
2002-12-02 9:21 (No subject) Marc-Christian Petersen
2002-10-17 21:58 (no subject) Daniele Lugli
2002-09-13 17:39 [No Subject] Jim Sibley
2002-09-13 18:02 ` Jesse Pollard
2002-08-25 9:15 <no subject> joerg.beyer
2002-08-25 11:04 ` Zwane Mwaikambo
2002-08-14 11:23 (no subject) Bernard yap
[not found] <Pine.LNX.4.44.0208131430570.22034-100000@dstl.gov.uk>
2002-08-13 6:35 ` Jeff Chua
2002-08-13 9:27 ` (no subject) Tony Gale
2002-07-20 8:00 close return value Florian Weimer
2002-07-20 16:45 ` Linus Torvalds
2002-07-26 0:06 ` EFAULT vs. SIGSEGV [was Re: close return value] Pavel Machek
2002-07-26 14:01 ` (no subject) Alexis Deruelle
2002-03-22 14:28 Pierre Rousselet
2002-03-01 2:55 Justin Piszcz
2002-02-11 15:02 Aaron & Elizabeth Day
2001-03-21 9:44 Moran Cohen
2001-01-10 1:40 Eko Sulistiono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f30057e-da61-55b4-adf7-e35d91798806@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).