From: Markus Elfring <Markus.Elfring@web.de>
To: Denis Efremov <efremov@linux.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <julia.lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [RFC PATCH] coccinelle: check for integer overflow in binary search
Date: Thu, 5 Sep 2019 14:32:54 +0200 [thread overview]
Message-ID: <8f454c56-735c-0620-ead4-b59e328b0283@web.de> (raw)
In-Reply-To: <20190904221223.5281-1-efremov@linux.com>
> +identifier l, h, m;
Can expressions make sense for these metavariables?
> +@@
> +(
> + while (\(l < h\|l <= h\|(h - l) > 1\|(l + 1) < h\|l < (h - 1)\)) {
> + ...
> +(
> + ((l + h)@p / c)
> +|
> + ((l + h)@p >> c)
> +)
> + ...
> + }
* I suggest again to look at further possibilities to reduce undesirable
code duplication also together with the usage of SmPL disjunctions.
* The condition specification might be easier to read with a few
additional spaces (or the following variant).
* The SmPL ellipses will probably need further considerations.
+@@
+(
+ while (
+( l \( < \| <= \) h
+| (h - l) > 1
+| (h - 1) > l
+| (l + 1) < h
+) )
+ {
+ <+...
+ ((l + h)@p \( / \| >> \) c)
+ ...+>
+ }
> +@script:python depends on report@
> +p << r.p;
> +@@
> +
> +msg="WARNING: custom implementation of bsearch is error-prone. "
> +msg+="Consider using lib/bsearch.c or fix the midpoint calculation "
> +msg+="as 'm = l + (h - l) / 2;' to prevent the arithmetic overflow."
> +coccilib.report.print_report(p[0], msg)
The Linux coding style supports to put a long string literal also into a single line.
Thus I find such a message construction nicer without the extra variable “msg”.
Regards,
Markus
next prev parent reply other threads:[~2019-09-05 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 22:12 [RFC PATCH] coccinelle: check for integer overflow in binary search Denis Efremov
2019-09-05 6:20 ` Julia Lawall
2019-09-05 7:36 ` Denis Efremov
2019-09-05 7:51 ` Julia Lawall
2019-09-05 12:32 ` Markus Elfring [this message]
2019-09-05 14:23 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f454c56-735c-0620-ead4-b59e328b0283@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).