From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756035AbcETMgA (ORCPT ); Fri, 20 May 2016 08:36:00 -0400 Received: from m199-177.yeah.net ([123.58.177.199]:9065 "EHLO m199-177.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556AbcETMf6 (ORCPT ); Fri, 20 May 2016 08:35:58 -0400 Subject: Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 To: Caesar Wang , Heiko Stuebner , Mark Brown References: <1463702182-5188-1-git-send-email-wxt@rock-chips.com> <1463702182-5188-3-git-send-email-wxt@rock-chips.com> Cc: shawn.lin@rock-chips.com, Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org From: Shawn Lin Message-ID: <8f662b3b-e359-efdf-72e5-c4f862dd1cf6@kernel-upstream.org> Date: Fri, 20 May 2016 20:35:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463702182-5188-3-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVUhISUJCQkJPT01DTUNDQk1XWQkOFx4IWU FZKCs9JDU#Li8pOjckMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkIj4oJD I1JDM#Oj8#KUFLVUtAODQuNS8pIiQ4NUFLVUtAKT48MjQ1JDooMjpBS1VLQCspNC0yNTg#JD0uMT I6NUFLVUtAPyI1OjYyOCQyKyQ1NCQyNSQzPjo*PilBS1VLQDYuNy8yJCk4Ky8kPzI9PT4pPjUvJD I1JDM#Oj8#KUFJVUtAMiskLzQ*OiIkODUvJEskSktLQUtVS0AyKyRKJDYyNS4vPiQ4NS8kSyRKS0 FLVUtAMiskSEskNjI1Li8#JDg1LyRLJE5LQUtVS0AyKyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAMi skSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44LyQvND86IiQ4NS8kSyRKS0tBS1VLQCguOTE#OC 8kSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44LyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAKDkxJD c#NSRPSyQjQUtVS0tKS0AvPiMvJDc#NSRISUskSklDS0FLVUtLSktAODUvJDMvNjckNz41JEowJE 4wQUtVS0tKS0ApPjg#Mi0#KSQ4NS8kTiQjQUtVS0tKS0AjNjoyNz4pJDUuNzdBS1VLS0pLQD8#Nz ItPikkNz41JEtBS1VLS0pLQDc6NTwkODVBS1VLS0pLQD01JDY6IiRPSkIkMzcxJEokS0NLSEtPQU tVSEhAPSskKT4kPSwkMzcxJEtDS0hLTUFWTFVOQD01JCguOSQ#NSw0KT8oJDM3MSRKS0tJS0pBS1 VJQ0AoLjkkPkFKVU5OQD01JDY6IiRPSkIkMzcxJEkkS0NLSEtPQUtVS1kG X-HM-Sender-Digest: e1kSHx4VD1lBWUc6KzI6Kjo*Tjo6DUwZETMMNiE4ThgKCgFVSlVKT01I TE9MTE5PSkxCVTMWGhIXVQgTGgwVVRcSFTsQHgkVHhdWDgsIDwkeGhZVFAkcRVlXWQweGVlBHRoX CB5XWQgBWUFISk9NN1dZEgtZQVlJSUtVSUtLVU5CVUxKWQY+ X-HM-Tid: 0a54ce2a38886427bae851104ada Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/5/20 7:56, Caesar Wang 写道: > That's seem the incorrect string to match the spi driver. > Will it break the backward compatibility for some dtb if not falling back to "rockchip,rockchip-spi" ? > Fixes commit f629fcfab2cd > ("ARM: dts: rockchip: support the spi for rk3036") > > Signed-off-by: Caesar Wang > Cc: Heiko Stuebner > Cc: linux-rockchip@lists.infradead.org > > --- > > Changes in v2: None > > arch/arm/boot/dts/rk3036.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi > index d0f4bb7..a30700a 100644 > --- a/arch/arm/boot/dts/rk3036.dtsi > +++ b/arch/arm/boot/dts/rk3036.dtsi > @@ -431,7 +431,7 @@ > }; > > spi: spi@20074000 { > - compatible = "rockchip,rockchip-spi"; > + compatible = "rockchip,rk3036-spi"; > reg = <0x20074000 0x1000>; > interrupts = ; > clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>; >