From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACC9C433DF for ; Sun, 5 Jul 2020 17:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A32E520708 for ; Sun, 5 Jul 2020 17:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgGERwy (ORCPT ); Sun, 5 Jul 2020 13:52:54 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:62714 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgGERwx (ORCPT ); Sun, 5 Jul 2020 13:52:53 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4B0GWL1WR1z9tyPL; Sun, 5 Jul 2020 19:52:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id V_KhQkkJwpw0; Sun, 5 Jul 2020 19:52:46 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4B0GWL0fMFz9tyPK; Sun, 5 Jul 2020 19:52:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EF0F88B780; Sun, 5 Jul 2020 19:52:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id lsEM1ItNQNVD; Sun, 5 Jul 2020 19:52:50 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 997028B75B; Sun, 5 Jul 2020 19:52:50 +0200 (CEST) Subject: Re: [PATCH 3/5] selftests/powerpc: Update the stack expansion test To: Michael Ellerman , linuxppc-dev@ozlabs.org Cc: linux-arch@vger.kernel.org, hughd@google.com, linux-kernel@vger.kernel.org References: <20200703141327.1732550-1-mpe@ellerman.id.au> <20200703141327.1732550-3-mpe@ellerman.id.au> From: Christophe Leroy Message-ID: <8f6c5175-32ce-34a2-873d-b5fb3a5d7c4c@csgroup.eu> Date: Sun, 5 Jul 2020 19:52:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200703141327.1732550-3-mpe@ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/07/2020 à 16:13, Michael Ellerman a écrit : > Update the stack expansion load/store test to take into account the > new allowance of 4096 bytes below the stack pointer. [I didn't receive patch 2, don't know why, hence commenting patch 2 here.] Shouldn't patch 2 carry a fixes tag and be Cced to stable for application to previous kernel releases ? Christophe > > Signed-off-by: Michael Ellerman > --- > .../selftests/powerpc/mm/stack_expansion_ldst.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > index 0587e11437f5..95c3f3de16a1 100644 > --- a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > +++ b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > @@ -186,17 +186,17 @@ static void test_one_type(enum access_type type, unsigned long page_size, unsign > // But if we go past the rlimit it should fail > assert(test_one(DEFAULT_SIZE, rlim_cur + 1, type) != 0); > > - // Above 1MB powerpc only allows accesses within 2048 bytes of > + // Above 1MB powerpc only allows accesses within 4096 bytes of > // r1 for accesses that aren't stdu > - assert(test_one(1 * _MB + page_size - 128, -2048, type) == 0); > + assert(test_one(1 * _MB + page_size - 128, -4096, type) == 0); > #ifdef __powerpc__ > - assert(test_one(1 * _MB + page_size - 128, -2049, type) != 0); > + assert(test_one(1 * _MB + page_size - 128, -4097, type) != 0); > #else > - assert(test_one(1 * _MB + page_size - 128, -2049, type) == 0); > + assert(test_one(1 * _MB + page_size - 128, -4097, type) == 0); > #endif > > // By consuming 2MB of stack we test the stdu case > - assert(test_one(2 * _MB + page_size - 128, -2048, type) == 0); > + assert(test_one(2 * _MB + page_size - 128, -4096, type) == 0); > } > > static int test(void) >