From: Luca Ceresoli <luca@lucaceresoli.net>
To: Adam Ford <aford173@gmail.com>, Rob Herring <robh@kernel.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties
Date: Wed, 13 Jan 2021 15:36:48 +0100 [thread overview]
Message-ID: <8f896ca0-d270-787c-74c9-2bca91ccf7f2@lucaceresoli.net> (raw)
In-Reply-To: <CAHCN7xKLRj=bbMQAXNDZ+8cHh+jon5Bb7GdQYpVUos91uiV5Tw@mail.gmail.com>
Hi Adam,
On 13/01/21 13:31, Adam Ford wrote:
> On Tue, Jan 12, 2021 at 9:16 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, Jan 06, 2021 at 11:38:59AM -0600, Adam Ford wrote:
>>> There are two registers which can set the load capacitance for
>>> XTAL1 and XTAL2. These are optional registers when using an
>>> external crystal. Update the bindings to support them.
>>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>> ---
>>> .../devicetree/bindings/clock/idt,versaclock5.yaml | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> index 2ac1131fd922..e5e55ffb266e 100644
>>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> @@ -59,6 +59,18 @@ properties:
>>> minItems: 1
>>> maxItems: 2
>>>
>>> + idt,xtal1-load-femtofarads:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>
>> Already has a type, so you can drop the $ref.
>>
>>> + minimum: 9000
>>> + maximum: 25000
>
> Luca,
>
> Do you want the range to the 9000 - 25000 per the datasheet, or should
> I use the max value based on the programmer guide? Currently, my
> intent was to cap the value to 11111b, so anyone who writes 23000,
> 24000, or 25000 will all be the same value based on the feedback I got
> from Renesas.
DT should describe the HW, so I'd use the same range that can be set in
hardware, regardless of driver support. Thus it should be:
9000 - [9000 + 430 * 32] = 9000 - 22760
--
Luca
prev parent reply other threads:[~2021-01-13 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 17:38 [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Adam Ford
2021-01-06 17:39 ` [RFC 2/2] clk: vc5: Add support for optional load capacitance Adam Ford
2021-01-08 22:49 ` Luca Ceresoli
2021-01-09 3:00 ` Adam Ford
2021-01-09 18:02 ` Luca Ceresoli
2021-01-11 16:40 ` Adam Ford
2021-01-12 16:45 ` Luca Ceresoli
2021-01-12 17:00 ` Adam Ford
2021-01-13 14:12 ` Luca Ceresoli
2021-01-13 7:23 ` Stephen Boyd
2021-01-08 22:49 ` [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Luca Ceresoli
2021-01-09 2:48 ` Adam Ford
2021-01-13 14:39 ` Luca Ceresoli
2021-01-13 3:16 ` Rob Herring
2021-01-13 12:31 ` Adam Ford
2021-01-13 14:36 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f896ca0-d270-787c-74c9-2bca91ccf7f2@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).