From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option
Date: Sat, 4 Sep 2021 11:33:20 +0800 [thread overview]
Message-ID: <8f8e4695-4062-60c4-0f91-2a1f6a5b0a11@kernel.org> (raw)
In-Reply-To: <CACOAw_yovM592K3-2fQzA6M29XqWu8s_2f+zXawKo-QpNSXq0w@mail.gmail.com>
On 2021/9/4 4:33, Daeho Jeong wrote:
>> if (f2fs_need_seq_seg(sbi))
>> return 0;
>>
>> static inline bool f2fs_need_seq_seg(struct f2fs_sb_info *sbi)
>> {
>> return F2FS_OPTION(sbi).fs_mode == FS_MODE_FRAGMENT_FIXED_BLK;
>> }
>>
>
> Do you need this in select_policy(), either?
IMO, for this mode, I prefer to disable background GC and just use newly
written userdata to fragment image, so I think it's fine to keep it as it is
here.
> Like,
> if (f2fs_need_rand_seg(sbi))
> p->offset = prandom_u32() % (MAIN_SECS(sbi) *
> sbi->segs_per_sec);
> else if (f2fs_need_seq_seg(sbi))
> p->offset = 0;
>
>> One more concern... we'd better to save fragment_remained_hole as well
>> as fragment_remained_chunk, otherwise, if fragment_chunk_size +
>> fragment_hole_size > 512, fragment hole will be truncated to 512 -
>> fragment_chunk_size due to we won't create hole with enough size as
>> seg->next_blkoff has crossed end of current segment.
>>
>
> Sorry, I don't get it. You mean making fragment_remained_hole as a
> global variable?
As a per curseg field.
> Maybe, we run into the same race condition issue you told before for
> fragment_remained_chunk.
> Could you clarify this more?
e.g.
F2FS_OPTION(sbi).fs_mode = FS_MODE_FRAGMENT_FIXED_BLK
fragment_chunk_size = 384
fragment_hole_size = 384
When creating hole:
- f2fs_allocate_data_block
- __refresh_next_blkoff
chunk locates in [0, 383] of current segment
seg->next_blkoff = 384
sbi->fragment_remained_chunk = 0
then we will reset sbi->fragment_remained_chunk to 384
and move seg->next_blkoff forward to 768 (384 + 384)
- __has_curseg_space() returns false
- allocate_segment() allocates new current segment
So, for such case that hole may cross two segments, hole size may be truncated
to left size of previous segment.
Thanks,
>
> Thanks,
>
next prev parent reply other threads:[~2021-09-04 3:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:24 [PATCH v4] f2fs: introduce fragment allocation mode mount option Daeho Jeong
2021-09-02 23:57 ` [f2fs-dev] " Chao Yu
2021-09-03 20:33 ` Daeho Jeong
2021-09-04 3:33 ` Chao Yu [this message]
2021-09-04 4:40 ` Daeho Jeong
2021-09-04 6:45 ` Chao Yu
2021-09-07 18:12 ` Daeho Jeong
2021-09-09 23:50 ` Chao Yu
2021-09-10 14:34 ` Daeho Jeong
2021-09-10 15:24 ` Daeho Jeong
2021-09-11 10:42 ` Chao Yu
2021-09-10 23:13 ` Jaegeuk Kim
2021-09-11 23:45 ` [f2fs-dev] " Chao Yu
2021-09-20 22:57 ` Jaegeuk Kim
2021-09-22 15:23 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f8e4695-4062-60c4-0f91-2a1f6a5b0a11@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).