From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6E8C2BB55 for ; Wed, 15 Apr 2020 10:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C61C32078A for ; Wed, 15 Apr 2020 10:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406020AbgDOKbV (ORCPT ); Wed, 15 Apr 2020 06:31:21 -0400 Received: from foss.arm.com ([217.140.110.172]:41762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405937AbgDOK32 (ORCPT ); Wed, 15 Apr 2020 06:29:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B1B21063; Wed, 15 Apr 2020 03:20:49 -0700 (PDT) Received: from [10.37.12.1] (unknown [10.37.12.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BE9B3F68F; Wed, 15 Apr 2020 03:20:47 -0700 (PDT) Subject: Re: [PATCH 4/8] arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com, maz@kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org, dianders@chromium.org, kernel-team@android.com References: <20200414213114.2378-1-will@kernel.org> <20200414213114.2378-5-will@kernel.org> From: Suzuki K Poulose Message-ID: <8f911640-8b7d-bb6f-2b76-67dd0d259b75@arm.com> Date: Wed, 15 Apr 2020 11:25:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200414213114.2378-5-will@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2020 10:31 PM, Will Deacon wrote: > There's no need to call id_aa64pfr0_32bit_el0() twice because the > sanitised value of ID_AA64PFR0_EL1 has already been updated for the CPU > being onlined. > > Remove the redundant function call. > > Signed-off-by: Will Deacon Reviewed-by: Suzuki K Poulose > --- > arch/arm64/kernel/cpufeature.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 838fe5cc8d7e..7dfcdd9e75c1 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -792,9 +792,7 @@ void update_cpu_features(int cpu, > * If we have AArch32, we care about 32-bit features for compat. > * If the system doesn't support AArch32, don't update them. > */ > - if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1)) && > - id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) { > - > + if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1))) { > taint |= check_update_ftr_reg(SYS_ID_DFR0_EL1, cpu, > info->reg_id_dfr0, boot->reg_id_dfr0); > taint |= check_update_ftr_reg(SYS_ID_ISAR0_EL1, cpu, >