From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: jens.wiklander@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: tee-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: optee: Fix compilation issue.
Date: Tue, 21 Jan 2020 14:23:02 +0000 [thread overview]
Message-ID: <8fa0e5b3-6e88-3fa2-9e16-046350cc752b@arm.com> (raw)
In-Reply-To: <20200110122807.49617-1-vincenzo.frascino@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]
Hi Greg,
I sent the fix below few days ago to the optee maintaners but I did not get any
answer. Could you please pick it up?
On 10/01/2020 12:28, Vincenzo Frascino wrote:
> The optee driver uses specific page table types to verify if a memory
> region is normal. These types are not defined in nommu systems. Trying
> to compile the driver in these systems results in a build error:
>
> linux/drivers/tee/optee/call.c: In function ‘is_normal_memory’:
> linux/drivers/tee/optee/call.c:533:26: error: ‘L_PTE_MT_MASK’ undeclared
> (first use in this function); did you mean ‘PREEMPT_MASK’?
> return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
> ^~~~~~~~~~~~~
> PREEMPT_MASK
> linux/drivers/tee/optee/call.c:533:26: note: each undeclared identifier is
> reported only once for each function it appears in
> linux/drivers/tee/optee/call.c:533:44: error: ‘L_PTE_MT_WRITEALLOC’ undeclared
> (first use in this function)
> return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
> ^~~~~~~~~~~~~~~~~~~
>
> Make the optee driver depend on MMU to fix the compilation issue.
>
> Cc: Jens Wiklander <jens.wiklander@linaro.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> drivers/tee/optee/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index d1ad512e1708..3ca71e3812ed 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -3,6 +3,7 @@
> config OPTEE
> tristate "OP-TEE"
> depends on HAVE_ARM_SMCCC
> + depends on MMU
> help
> This implements the OP-TEE Trusted Execution Environment (TEE)
> driver.
>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
next prev parent reply other threads:[~2020-01-21 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 12:28 [PATCH] drivers: optee: Fix compilation issue Vincenzo Frascino
2020-01-21 14:23 ` Vincenzo Frascino [this message]
2020-01-21 15:20 ` Greg Kroah-Hartman
2020-01-21 15:27 ` Vincenzo Frascino
2020-01-21 17:18 ` Greg Kroah-Hartman
2020-01-22 8:03 ` Jens Wiklander
2020-01-22 9:37 ` Vincenzo Frascino
2020-01-23 10:15 ` Jens Wiklander
2020-01-22 9:36 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fa0e5b3-6e88-3fa2-9e16-046350cc752b@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).