From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932678AbcH2LIZ (ORCPT ); Mon, 29 Aug 2016 07:08:25 -0400 Received: from mout.web.de ([212.227.15.14]:59218 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757255AbcH2LIY (ORCPT ); Mon, 29 Aug 2016 07:08:24 -0400 Subject: [PATCH 1/5] powerpc-mpic: Use kmalloc_array() in mpic_init() To: linuxppc-dev@lists.ozlabs.org, Adam Buchbinder , Andrew Donnellan , Benjamin Herrenschmidt , Marc Zyngier , Michael Ellerman , Paul Mackerras , Scott Wood , Sudeep Holla , Thomas Gleixner References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <8fe4b2fb-c27d-4932-bbcc-23899afa932d@users.sourceforge.net> Date: Mon, 29 Aug 2016 13:07:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3YR5Hl7EPlF1GA9N2N+ZY9/nXZ+XepXTgWomlxC/fENFJSBsrGn rZ/ai4vi5HXKCl6PjBuSJPGVm0zm0u+vVJCo85JORueaSVj1ixf8R0HIKUI/WmFvrskmKH6 j81uiAv9OsvoJ9muWWR6dwrpHYpE5SnSTZZU68qi7jhGW4Yk5RUdDupYBe/wadwDhPV81aw U5k3VR3EoQpBRuwYe1pXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:kOsB5uTZ8t0=:oHBvknylndLPYnxiXz15fJ 04y98oGJQnssIA7D48EvI56PmQJtUn/yzVejph3S+R1D/E/gkzm0QR76GIwDN3U7hNY2Zo2kL 4PF6FCYtmhv9yIN/8NoW4GzNxqAvOWT9HOaYJkLIEiN9mC6hLHk1dxECElA+7MHec9yc3uHm+ 2hVpHE1XD34zDi0yXFQqbjVNOFMl8S83phL5rxfaemWuy1Tvz6jbVgGLxUIsmK8ukgW84WbgB ZjROhzl3l7R+gABRt5xZpeV+vWnJ6hHcJ88jp9F5yUHfjcyamO0/eAglF8nueX8m9z4ByOx7x KygEAyKpL3300S4PesvjURS7E8bbUmzgEuzSqWSOcOtj2bGzWbzJrLZ79SQqDflu1jIiL1Eay 14OYvjdUaCgQ0sgukAkIki9wEr2RxQC48yiLuOeu1nUdjm4YiNtGrN5zUwqR/xxudFhO8Ch1y fDb1HPRmwlOkkpTonNVAH4z2wQ1ND0bm/H0VhiAtZfFr6+GgKoNQME0DTVNBI6LL21EmAPkdm bP1daJj6Gb1y5xKtJfA8O1ueWtKpW6FLOpaOFbmOMuxy+nqYTNCuzs54gY8wz7GgzLl5uvrak WnoQCrjSHy4LOcx4kZl4I0GicfNM9K3Ay3JHnQcfggmsVFzF7g92T68ZfoaVDcUd/yqYEDFTd Pd7lS3bLFAph/+kk2PHTJUPcnMy0qA0HdZz11FCcw+OhFMqGKpzPObmNpM+gMkXyVGKA3YCrP dF7Ivod3YcNx4xoJ6D4I1Yr/v96DZMUOK6z66knK9nV9SvTHLxUBjYZ8RDV6h5Ivv/Yv6d0kq uqa+F4s Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 29 Aug 2016 11:00:11 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/sysdev/mpic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c index 7de45b2..5e79c0d24 100644 --- a/arch/powerpc/sysdev/mpic.c +++ b/arch/powerpc/sysdev/mpic.c @@ -1641,8 +1641,9 @@ void __init mpic_init(struct mpic *mpic) #ifdef CONFIG_PM /* allocate memory to save mpic state */ - mpic->save_data = kmalloc(mpic->num_sources * sizeof(*mpic->save_data), - GFP_KERNEL); + mpic->save_data = kmalloc_array(mpic->num_sources, + sizeof(*mpic->save_data), + GFP_KERNEL); BUG_ON(mpic->save_data == NULL); #endif -- 2.9.3