Re: [PATCH v10, 4/4] mailbox: mtk-cmdq: add MT8186 support

["Yongqiang Niu (牛永强)" <yongqiang.niu@mediatek.com>]

hi jassi

do you have any comment about this series patch?



On Tue, 2022-10-18 at 05:52 +0000, CK Hu (胡俊光) wrote:
> Hi, Yongqiang:
> 
> On Mon, 2022-10-10 at 16:50 +0800, Yongqiang Niu wrote:
> > add MT8186 cmdq support
> 
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> 
> > 
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> > b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 53904511598d..c5229f377c5e 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -694,9 +694,18 @@ static const struct gce_plat gce_plat_v6 = {
> >  	.gce_num = 2
> >  };
> >  
> > +static const struct gce_plat gce_plat_v7 = {
> > +	.thread_nr = 24,
> > +	.shift = 3,
> > +	.control_by_sw = true,
> > +	.sw_ddr_en = true,
> > +	.gce_num = 1
> > +};
> > +
> >  static const struct of_device_id cmdq_of_ids[] = {
> >  	{.compatible = "mediatek,mt8173-gce", .data = (void
> > *)&gce_plat_v2},
> >  	{.compatible = "mediatek,mt8183-gce", .data = (void
> > *)&gce_plat_v3},
> > +	{.compatible = "mediatek,mt8186-gce", .data = (void
> > *)&gce_plat_v7},
> >  	{.compatible = "mediatek,mt6779-gce", .data = (void
> > *)&gce_plat_v4},
> >  	{.compatible = "mediatek,mt8192-gce", .data = (void
> > *)&gce_plat_v5},
> >  	{.compatible = "mediatek,mt8195-gce", .data = (void
> > *)&gce_plat_v6},