From: David Brown <davidb@codeaurora.org>
To: Greg KH <gregkh@suse.de>
Cc: Prashant Shah <pshah.mumbai@gmail.com>,
Stepan Moskovchenko <stepanm@codeaurora.org>,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
Daniel Walker <dwalker@codeaurora.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: msm: fixed style issues found by checkpatch.pl
Date: Wed, 06 Jul 2011 14:37:26 -0700 [thread overview]
Message-ID: <8yay60bytt5.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <20110706192656.GA30532@suse.de> (Greg KH's message of "Wed, 6 Jul 2011 12:26:56 -0700")
On Wed, Jul 06 2011, Greg KH wrote:
> On Wed, Jul 06, 2011 at 09:45:08PM +0530, Prashant Shah wrote:
>> Hi,
>>
>> > So that would be one patch for fixing extra braces, one for extra
>> > spaces, and so on. That makes it easier to review.
>>
>> Ok I will redo them.
>>
>> On Wed, Jul 6, 2011 at 9:27 PM, Greg KH <gregkh@suse.de> wrote:
>> > On Wed, Jul 06, 2011 at 01:19:34PM +0530, Prashant P. Shah wrote:
>> > Also, did you successfully build this code before and after your
>> > changes?
>>
>> I tried but the code does not build because of #include <mach/board.h>
>> in the msm_fb.c file. I dont know how to fix that.
>
> I say let's just delete this whole directory as if it doesn't build, no
> one is using it, and no one has tried to clean it up since it was
> originally added.
>
> Stepan or David or Abhijeet or Daniel, any objection to just deleting
> drivers/staging/msm/ at this point in time for the 3.1 kernel release?
> You haven't sent any patches to me to clean this code up since the
> original patch, way over a year ago.
I have none. The non-staging driver has been getting updates, and I
asked the author if it was OK to remove the staging one. I believe the
real driver supports everything the staging one did.
Should I generate a (large) patch, or is it easier for you to just
remove the tree?
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-07-06 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 7:49 [PATCH] Staging: msm: fixed style issues found by checkpatch.pl Prashant P. Shah
2011-07-06 15:57 ` Greg KH
2011-07-06 15:57 ` Greg KH
2011-07-06 16:15 ` Prashant Shah
2011-07-06 16:17 ` Prashant Shah
2011-07-06 19:26 ` Greg KH
2011-07-06 21:37 ` David Brown [this message]
2011-07-06 21:43 ` Greg KH
2011-07-06 22:53 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yay60bytt5.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=devel@driverdev.osuosl.org \
--cc=dwalker@codeaurora.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).