From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control
Date: Wed, 11 Aug 2021 21:36:52 +0800 [thread overview]
Message-ID: <90182f6a-9582-f1a6-e6b6-8f4088e80ce0@kernel.org> (raw)
In-Reply-To: <20210811131826.223141-1-frank.li@vivo.com>
On 2021/8/11 21:18, Yangtao Li wrote:
> Release f2fs_issue_discard every time it is destroyed,
> otherwise it will cause memory leaks when remounting.
I didn't get the problem here, could you please explain a bit more about
details?
Thanks,
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index afe20c5c3c08..363779a4402d 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1741,6 +1741,7 @@ void f2fs_stop_discard_thread(struct f2fs_sb_info *sbi)
>
> dcc->f2fs_issue_discard = NULL;
> kthread_stop(discard_thread);
> + put_task_struct(discard_thread);
> }
> }
>
> @@ -2168,6 +2169,7 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
> SM_I(sbi)->dcc_info = NULL;
> return err;
> }
> + get_task_struct(dcc->f2fs_issue_discard);
>
> return err;
> }
>
prev parent reply other threads:[~2021-08-11 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:18 [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control Yangtao Li
2021-08-11 13:18 ` [PATCH 2/2] fs: Don't create discard thread when device not support realtime discard Yangtao Li
2021-08-11 13:44 ` Chao Yu
2021-08-11 13:36 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90182f6a-9582-f1a6-e6b6-8f4088e80ce0@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).