From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbdEBUh1 (ORCPT ); Tue, 2 May 2017 16:37:27 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:37462 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbdEBUhY (ORCPT ); Tue, 2 May 2017 16:37:24 -0400 From: Chris Packham To: Guenter Roeck CC: "linux-hwmon@vger.kernel.org" , Jean Delvare , Jonathan Corbet , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing Thread-Topic: [RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing Thread-Index: AQHSwwdjEAy47K1r/kq0Gs5ri8mqEw== Date: Tue, 2 May 2017 20:37:18 +0000 Message-ID: <901bdec40a0344f3adb077756263a1d4@svr-chch-ex1.atlnz.lc> References: <20170502054536.21147-1-chris.packham@alliedtelesis.co.nz> <20170502054536.21147-4-chris.packham@alliedtelesis.co.nz> <20170502191354.GB11901@roeck-us.net> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:cc8a:ef50:953:3a05] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v42Kbl7s012081 On 03/05/17 07:14, Guenter Roeck wrote: > On Tue, May 02, 2017 at 05:45:36PM +1200, Chris Packham wrote: >> When enabled temperature smoothing allows ramping the fan speed over a >> configurable period of time instead of jumping to the new speed >> instantaneously. >> >> Signed-off-by: Chris Packham >> --- >> Documentation/hwmon/adt7475 | 5 ++ >> drivers/hwmon/adt7475.c | 121 ++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 126 insertions(+) >> >> diff --git a/Documentation/hwmon/adt7475 b/Documentation/hwmon/adt7475 >> index 85dc9e17bdee..31b15cb910ea 100644 >> --- a/Documentation/hwmon/adt7475 >> +++ b/Documentation/hwmon/adt7475 >> @@ -114,6 +114,11 @@ at the minimum (i.e. auto_point1_pwm). This can be configured using the >> pwm[1-*]_min sysfs attribute. A value of 0 means the fans will shut off. A >> value of 1 means the fans will run at auto_point1_pwm. >> >> +The responsiveness of the ADT747x to temperature changes can be configured. >> +This allows smoothing of the fan speed transition. To enable temperature >> +smoothing used the temp[1-*]_smoothing_enable sysfs attribute. To set the >> +transition time set the value in ms in the temp[1-*]_smoothing sysfs attribute. >> + > Does this require two attributes, or can setting '0' for temp[1-*]_smoothing > be used to disable it ? > One attribute could be made to work. I was following asc7621.c but from a usability perspective having to set the two attributes is not particularly convenient. The only argument for separating them is to allow smoothing at whatever the hardware default is.