From: Stephen Kitt <steve@sk2.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-man <linux-man@vger.kernel.org>,
Alejandro Colomar <alx.manpages@gmail.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] close_range.2: new page documenting close_range(2)
Date: Wed, 09 Dec 2020 10:43:16 +0100 [thread overview]
Message-ID: <9020961b9cb4ebc61d6a07f603a226aa@sk2.org> (raw)
In-Reply-To: <20201209094039.ksqlt7g5mq7mp4mq@wittgenstein>
Le 09/12/2020 10:40, Christian Brauner a écrit :
> On Wed, Dec 09, 2020 at 09:50:38AM +0100, Michael Kerrisk (man-pages)
> wrote:
>> > +.PP
>> > +.I flags
>> > +can be set to
>> > +.B CLOSE_RANGE_UNSHARE
>> > +to unshare the range of file descriptors from any other processes,
>> > +.I instead
>> > +of closing them.
>>
>> Really "instead of closing them"? I had supposed that rather that this
>> should be "before closing them". That's also how the kernel code reads
>> to me, from a quick glance.
>
> It's also mentioned in the commit message. Basically setting
> CLOSE_RANGE_UNSHARE is equivalent to:
>
> unshare(CLONE_FILES);
> close_range(<start>, <end>);
Yes, I got that mixed up, thanks for the clarification! I'll send a v2
addressing the review comments later today.
Regards,
Stephen
next prev parent reply other threads:[~2020-12-09 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 21:51 [patch] close_range.2: new page documenting close_range(2) Stephen Kitt
2020-12-09 8:50 ` Michael Kerrisk (man-pages)
2020-12-09 9:40 ` Christian Brauner
2020-12-09 9:43 ` Stephen Kitt [this message]
2020-12-09 9:47 ` Alejandro Colomar (man-pages)
2020-12-10 22:40 ` Michael Kerrisk (man-pages)
2020-12-09 9:58 ` Christian Brauner
2020-12-09 10:44 ` Alejandro Colomar (man-pages)
2020-12-09 10:56 ` Christian Brauner
2020-12-10 14:36 ` Alejandro Colomar (man-pages)
2020-12-12 12:14 ` Christian Brauner
2020-12-12 17:58 ` Alejandro Colomar (man-pages)
2020-12-18 10:12 ` Ping: " Alejandro Colomar (man-pages)
2020-12-18 10:14 ` Stephen Kitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9020961b9cb4ebc61d6a07f603a226aa@sk2.org \
--to=steve@sk2.org \
--cc=alx.manpages@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).