Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page() static"

[John Hubbard <jhubbard@nvidia.com>]

...
>> LD      vmlinux
>> BTFIDS  vmlinux
>> FAILED elf_update(WRITE): no error
> 
> This elf_update(WRITE) error is new to me.
> 
>> make: *** [Makefile:1176: vmlinux] Error 255
>> make: *** Deleting file 'vmlinux'
> 
> It is annoying that vmlinux is deleted in this case, because I usually give Jiri the output from 
> 'resolve_btfids -v' on vmlinux.
> 
>   $ ./tools/bpf/resolve_btfids/resolve_btfids -v vmlinux.failed
> 
> You can do:
> $ git diff
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 3b261b0f74f0..02dec10a7d75 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -302,7 +302,8 @@ cleanup()
>          rm -f .tmp_symversions.lds
>          rm -f .tmp_vmlinux*
>          rm -f System.map
> -       rm -f vmlinux
> +       # rm -f vmlinux
> +       mv vmlinux vmlinux.failed
>          rm -f vmlinux.o
>   }
> 
> 
>>
>>
>> ...and un-setting CONFIG_DEBUG_INFO_BTF makes that disappear. Maybe someone
>> who is understands the BTFIDS build step can shed some light on that; I'm
>> not there yet. :)
> 
> I'm just a user/consume of output from the BTFIDS build step, I think Jiri Olsa own the tool 
> resolve_btfids, and ACME pahole.  I've hit a number of issues in the past that Jiri and ACME help 
> resolve quickly.
> The most efficient solution I've found was to upgrade pahole to a newer version.
> 
> What version of pahole does your build system have?
> 
> What is your GCC version?
> 

Just a quick answer first on the versions: this is an up to date Arch Linux system:

gcc: 11.1.0
pahole: 1.21

I'll try to get the other step done later this evening.

thanks,
-- 
John Hubbard
NVIDIA