From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46BDCC433B4 for ; Fri, 14 May 2021 00:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B37E611C9 for ; Fri, 14 May 2021 00:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231812AbhENAnz (ORCPT ); Thu, 13 May 2021 20:43:55 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2480 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbhENAny (ORCPT ); Thu, 13 May 2021 20:43:54 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Fh8nC3ZDxzBtT2; Fri, 14 May 2021 08:39:59 +0800 (CST) Received: from [10.174.179.71] (10.174.179.71) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 14 May 2021 08:42:37 +0800 Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API To: "Rafael J. Wysocki" , Heikki Krogerus CC: Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Jean-Philippe Brucker , Joerg Roedel , Eric Auger , Will Deacon , ACPI Devel Maling List , "Linux ARM" , Linux Kernel Mailing List References: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> From: Hanjun Guo Message-ID: <9026d9a3-9f17-6686-d64e-009326ec6e90@huawei.com> Date: Fri, 14 May 2021 08:42:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.71] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/11 21:51, Rafael J. Wysocki wrote: > On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus > wrote: >> The older device property API is going to be removed. >> Replacing the device_add_properties() call with software >> node API equivalent device_create_managed_software_node(). >> >> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits") >> Signed-off-by: Heikki Krogerus >> --- >> drivers/acpi/arm64/iort.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c >> index 3912a1f6058e5..e34937e11186a 100644 >> --- a/drivers/acpi/arm64/iort.c >> +++ b/drivers/acpi/arm64/iort.c >> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, >> FIELD_GET(ACPI_IORT_NC_PASID_BITS, >> nc->node_flags)); >> >> - if (device_add_properties(dev, props)) >> + if (device_create_managed_software_node(dev, props, NULL)) >> dev_warn(dev, "Could not add device properties\n"); >> } >> >> -- > Thanks! > > I can take this through the ACPI tree if there are no objections. Since this is related to device property API refactor, I'm fine with it. Lorenzo, what's your position? Thanks Hanjun