From: James Clark <james.clark@arm.com>
To: Leo Yan <leo.yan@linaro.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Al Grant <Al.Grant@arm.com>, John Garry <john.garry@huawei.com>,
Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event
Date: Thu, 15 Apr 2021 17:46:31 +0300 [thread overview]
Message-ID: <9036368a-e824-3d63-da5b-54cf32a86aed@arm.com> (raw)
In-Reply-To: <20210412091006.468557-5-leo.yan@linaro.org>
On 12/04/2021 12:10, Leo Yan wrote:
> In current code, it assigns the arch timer counter to the synthesized
> samples Arm SPE trace, thus the samples don't contain the kernel time
> but only contain the raw counter value.
>
> To fix the issue, this patch converts the timer counter to kernel time
> and assigns it to sample timestamp.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/arm-spe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
> index 23714cf0380e..c13a89f06ab8 100644
> --- a/tools/perf/util/arm-spe.c
> +++ b/tools/perf/util/arm-spe.c
> @@ -234,7 +234,7 @@ static void arm_spe_prep_sample(struct arm_spe *spe,
> struct arm_spe_record *record = &speq->decoder->record;
>
> if (!spe->timeless_decoding)
> - sample->time = speq->timestamp;
> + sample->time = tsc_to_perf_time(record->timestamp, &spe->tc);
I noticed that in arm_spe_recording_options() the TIME sample bit is set regardless of any options.
I don't know of a way to remove this, and if there isn't, does that mean that all the code in this
file that looks at spe->timeless_decoding is untested and has never been hit?
Unless there is a way to get a perf file with only the AUXTRACE event and no others? I think that one
might have no timestamp set. Otherwise other events will always have timestamps so spe->timeless_decoding
is always false.
>
> sample->ip = record->from_ip;
> sample->cpumode = arm_spe_cpumode(spe, sample->ip);
>
next prev parent reply other threads:[~2021-04-15 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 9:10 [PATCH v4 0/6] perf arm-spe: Enable timestamp Leo Yan
2021-04-12 9:10 ` [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS Leo Yan
2021-04-15 14:13 ` James Clark
2021-04-15 14:41 ` Leo Yan
2021-04-15 14:49 ` James Clark
2021-04-12 9:10 ` [PATCH v4 2/6] perf arm-spe: Save clock parameters from TIME_CONV event Leo Yan
2021-04-12 9:10 ` [PATCH v4 3/6] perf arm-spe: Convert event kernel time to counter value Leo Yan
2021-04-12 9:10 ` [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event Leo Yan
2021-04-15 14:46 ` James Clark [this message]
2021-04-15 15:23 ` Leo Yan
2021-04-16 12:51 ` James Clark
2021-04-16 13:21 ` Leo Yan
2021-04-29 15:23 ` Leo Yan
2021-04-12 9:10 ` [PATCH v4 5/6] perf arm-spe: Bail out if the trace is later than perf event Leo Yan
2021-04-12 9:10 ` [PATCH v4 6/6] perf arm-spe: Don't wait for PERF_RECORD_EXIT event Leo Yan
2021-04-15 14:43 ` [PATCH v4 0/6] perf arm-spe: Enable timestamp James Clark
2021-04-15 14:56 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9036368a-e824-3d63-da5b-54cf32a86aed@arm.com \
--to=james.clark@arm.com \
--cc=Al.Grant@arm.com \
--cc=Dave.Martin@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).