From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087FCC10F14 for ; Tue, 23 Apr 2019 13:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF97B206A3 for ; Tue, 23 Apr 2019 13:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbfDWNKk (ORCPT ); Tue, 23 Apr 2019 09:10:40 -0400 Received: from ns.iliad.fr ([212.27.33.1]:52196 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbfDWNKh (ORCPT ); Tue, 23 Apr 2019 09:10:37 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 01AB6205F9; Tue, 23 Apr 2019 15:10:36 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id DDBC1205F8; Tue, 23 Apr 2019 15:10:35 +0200 (CEST) Subject: Re: [PATCH v2 00/13] qcom: dts: thermal cleanups To: Amit Kucheria Cc: Andy Gross , LKML , MSM , Bjorn Andersson , Sibi Sankar References: <5583cae1-8fea-724a-24a4-59b38a205ac3@free.fr> <842b06c6-15b2-7ba6-702e-c8b043d390a6@free.fr> From: Marc Gonzalez Message-ID: <903fa0a6-5c40-97b4-1c01-fd84f3e51c62@free.fr> Date: Tue, 23 Apr 2019 15:10:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Tue Apr 23 15:10:36 2019 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/2019 14:56, Amit Kucheria wrote: > On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez wrote: > >> On 02/04/2019 20:46, Amit Kucheria wrote: >> >>> On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: >>> >>>> On 29/03/2019 11:12, Amit Kucheria wrote: >>>> >>>>> Changes since v1: >>>>> - Devices that are not associated with cooling-maps use the 'hot' type >>>>> - Remove critical trip from such devices too and restrict that type of CPUs >>>>> - For 8916, add the sensor on the modem >>>>> >>>>> Description: >>>>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845 >>>>> - split up the register address map for msm8998 >>>>> - standardize names of the various thermal-zones across boards to make it >>>>> easy for test scripts to parse >>>> >>>> This is what I see on msm8998 with your patch series applied on top of >>>> yesterday's next: >>>> >>>> # dmesg | grep of_parse_thermal_zones >>>> of_parse_thermal_zones: build cpu0-thermal zone 0 >>>> of_parse_thermal_zones: build cpu1-thermal zone 0 >>>> of_parse_thermal_zones: build cpu2-thermal zone 0 >>>> of_parse_thermal_zones: build cpu3-thermal zone 0 >>>> of_parse_thermal_zones: build cpu4-thermal zone 0 >>>> of_parse_thermal_zones: build cpu5-thermal zone 0 >>>> of_parse_thermal_zones: build cpu6-thermal zone 0 >>>> of_parse_thermal_zones: build cpu7-thermal zone 0 >>>> of_parse_thermal_zones: build gpu-thermal-bottom zone 0 >>>> of_parse_thermal_zones: build gpu-thermal-top zone 0 >>>> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22 >>>> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22 >>>> of_parse_thermal_zones: build cluster1-l2-thermal zone 0 >>>> of_parse_thermal_zones: build modem-thermal zone 0 >>>> of_parse_thermal_zones: build mem-thermal zone 0 >>>> of_parse_thermal_zones: build wlan-thermal zone 0 >>>> of_parse_thermal_zones: build q6-dsp-thermal zone 0 >>>> of_parse_thermal_zones: build camera-thermal zone 0 >>>> of_parse_thermal_zones: build multimedia-thermal zone 0 >>>> of_parse_thermal_zones: build pm8998 zone 0 >>>> of_parse_thermal_zones: build battery-thermal zone 0 >>>> of_parse_thermal_zones: build skin-thermal zone 0 >>>> >>>> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal >>>> >>>> >>>> # cat /sys/devices/virtual/thermal/thermal_zone*/temp >>>> 35800 >>>> 35200 >>>> 34500 >>>> 34800 >>>> 34500 >>>> 34100 >>>> 34100 >>>> 33500 >>>> 33800 >>>> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument >>>> 36100 >>>> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument >>>> 35500 >>>> 36100 >>>> 35800 >>>> 35200 >>>> 35500 >>>> 36100 >>>> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument >>>> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument >>>> >>>> >>>> Are the failures expected? >>>> (cluster*-mhm-thermal and thermal_zone*/temp) >>> >>> No they are not. Unfortunately, I didn't have HW to test, so >>> appreciate the help with testing. I'll check the 8, 9, 17 and 19 again >>> before resubmitting. >> >> Looks like Andy merged this series? > > Argh! my bad, I completely forgot about the need to fix this up. I > need to get me one of these boards. > >> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next >> >> I was expecting a respin, or a discussion of the failures. >> >> Slightly confused. What next? > > We can either revert that one patch for the msm8998, but I think it > might be better if I send a fixup patch that could fixup those 4 zones > instead. > > Does that work for you? Sure. I can give you a Tested-by once everything works on the MEDIABOX I have. You mention the 4 thermal_zone*/temp failures. What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures? Regards.