From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101F7C433FE for ; Tue, 21 Sep 2021 10:52:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E951161131 for ; Tue, 21 Sep 2021 10:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232155AbhIUKyM (ORCPT ); Tue, 21 Sep 2021 06:54:12 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:45683 "EHLO mail-ed1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232060AbhIUKyL (ORCPT ); Tue, 21 Sep 2021 06:54:11 -0400 Received: by mail-ed1-f53.google.com with SMTP id c22so72460849edn.12; Tue, 21 Sep 2021 03:52:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=STQ1SYPDR3l1tp+29Ksawhjtp3/4UkFtTcVlzO20jxw=; b=eYEEEHY7Yc5Jp+UniIVV9z6z0e7nWxGRT0U7OQim/zRmuUsh7D4BqRX7ikyQICrazc hCgFsxRgVaaDRdWkSfeprfD+ODGF7IPT7NZghF1uKKt+BnVWdolACy3IBXZUTFj1v+kF suUs2NFKCyqyWbRT0jhsab11arF5/ZYKO/MiqG06h3UArFSuaLZkqxKFoNfTGj8AseNd OmeZxHd7aWdQeKyo4ov0r9yUglCQjdocsQO4PLG/Rpw6iiJ8+6wQNz3l2lEphRvmbXaz +SlJkOLXsC1/WvuHu4l8bBif9lfGBSyexLkzS0jhex8xEfYI2ZvH6Bla0NsySlRBTcT/ 9ZGA== X-Gm-Message-State: AOAM530uyk+RTt6eEnhaWogKESv00CJMGi776YHKKZQ0Hp4/O/ziIieU 3zcvHsTwy3o70HHKIEQkGj9JPgAoAAQ= X-Google-Smtp-Source: ABdhPJzV8kO9F47YfqiJ4yR/67N6EPeYnE5Lb57mIqp/kxCSXyTqietIepnIBS8SxLdoCnSBkVZnxw== X-Received: by 2002:a50:bf02:: with SMTP id f2mr21867212edk.98.1632221562314; Tue, 21 Sep 2021 03:52:42 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id 10sm5689589ejo.111.2021.09.21.03.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 03:52:41 -0700 (PDT) Message-ID: <9049e956-2865-7309-2eaf-aa4516ab28d6@kernel.org> Date: Tue, 21 Sep 2021 12:52:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl Content-Language: en-US To: Dmitry Torokhov Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Andreas Koensgen , Paul Mackerras , Krzysztof Kozlowski References: <20210914091134.17426-1-jslaby@suse.cz> <20210914091134.17426-7-jslaby@suse.cz> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 09. 21, 6:00, Dmitry Torokhov wrote: > Hi Jiri, > > On Tue, Sep 14, 2021 at 11:11:25AM +0200, Jiri Slaby wrote: >> diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c >> index 17eb8f2aa48d..55e91d0e70ec 100644 >> --- a/drivers/input/serio/serport.c >> +++ b/drivers/input/serio/serport.c >> @@ -207,8 +207,8 @@ static void serport_set_type(struct tty_struct *tty, unsigned long type) >> * serport_ldisc_ioctl() allows to set the port protocol, and device ID >> */ >> >> -static int serport_ldisc_ioctl(struct tty_struct *tty, struct file *file, >> - unsigned int cmd, unsigned long arg) >> +static int serport_ldisc_ioctl(struct tty_struct *tty, unsigned int cmd, >> + unsigned long arg) > > Can we please keep arguments aligned as they were? Otherwise Fixed, thanks. Likely, I will send a follow-up -- depending if Greg drops or keeps these in the tree. -- js suse labs