From: Xingang Wang <wangxingang5@huawei.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: <robh@kernel.org>, <will@kernel.org>, <helgaas@kernel.org>,
<robh+dt@kernel.org>, <gregkh@linuxfoundation.org>,
<iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<xieyingtai@huawei.com>
Subject: Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices
Date: Mon, 7 Jun 2021 20:43:53 +0800 [thread overview]
Message-ID: <9054b39b-a73c-f5b4-cd61-9af4449a0649@huawei.com> (raw)
In-Reply-To: <YLpIcwdWDGKpw39s@8bytes.org>
On 2021/6/4 23:36, Joerg Roedel wrote:
> On Fri, May 21, 2021 at 03:03:24AM +0000, Wang Xingang wrote:
>> From: Xingang Wang <wangxingang5@huawei.com>
>>
>> When booting with devicetree, the pci_request_acs() is called after the
>> enumeration and initialization of PCI devices, thus the ACS is not
>> enabled. And ACS should be enabled when IOMMU is detected for the
>> PCI host bridge, so add check for IOMMU before probe of PCI host and call
>> pci_request_acs() to make sure ACS will be enabled when enumerating PCI
>> devices.
>>
>> Fixes: 6bf6c24720d33 ("iommu/of: Request ACS from the PCI core when
>> configuring IOMMU linkage")
>> Signed-off-by: Xingang Wang <wangxingang5@huawei.com>
>> ---
>> drivers/iommu/of_iommu.c | 1 -
>> drivers/pci/of.c | 8 +++++++-
>> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> Should probably go through the PCI tree, so
>
> Acked-by: Joerg Roedel <jroedel@suse.de>
>
> .
>
Thanks
.
next prev parent reply other threads:[~2021-06-07 12:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 3:03 [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices Wang Xingang
2021-05-21 19:03 ` Rob Herring
2021-05-31 11:24 ` Xingang Wang
2021-06-04 15:36 ` Joerg Roedel
2021-06-07 12:43 ` Xingang Wang [this message]
2021-06-04 19:04 ` Bjorn Helgaas
2021-06-07 12:58 ` Xingang Wang
2021-06-08 10:23 ` John Garry
2021-06-28 13:20 ` Xingang Wang
2021-08-20 19:57 ` Bjorn Helgaas
2021-09-02 14:46 ` Bjorn Helgaas
[not found] ` <CGME20210901085937eucas1p2d02da65cac797706ca3a10b8a2eb8ba2@eucas1p2.samsung.com>
2021-09-01 8:59 ` Marek Szyprowski
2021-09-01 9:58 ` Robin Murphy
2021-09-02 12:51 ` Anders Roxell
2021-09-02 13:07 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9054b39b-a73c-f5b4-cd61-9af4449a0649@huawei.com \
--to=wangxingang5@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).