From: David Hildenbrand <david@redhat.com>
To: Kees Cook <keescook@chromium.org>, Russell King <linux@armlinux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>,
Martin Oliveira <martin.oliveira@eideticom.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>, Zi Yan <ziy@nvidia.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Minchan Kim <minchan@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-arm-kernel@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ARM/dma-mapping: Remove CMA code when not built with CMA
Date: Thu, 10 Mar 2022 09:23:44 +0100 [thread overview]
Message-ID: <9059fa71-330f-f04f-b155-2850abb72a71@redhat.com> (raw)
In-Reply-To: <20220309175107.195182-1-keescook@chromium.org>
On 09.03.22 18:51, Kees Cook wrote:
> The MAX_CMA_AREAS could be set to 0, which would result in code that would
> attempt to operate beyond the end of a zero-sized array. If CONFIG_CMA
> is disabled, just remove this code entirely. Found when building with
> -Warray-bounds:
>
> arch/arm/mm/dma-mapping.c:396:22: warning: array subscript <unknown> is outside array bounds of 'str
> uct dma_contig_early_reserve[0]' [-Warray-bounds]
> 396 | dma_mmu_remap[dma_mmu_remap_num].size = size;
> | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
> arch/arm/mm/dma-mapping.c:389:40: note: while referencing 'dma_mmu_remap'
> 389 | static struct dma_contig_early_reserve dma_mmu_remap[MAX_CMA_AREAS] __initdata;
> | ^~~~~~~~~~~~~
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Logan Gunthorpe <logang@deltatee.com>
> Cc: Martin Oliveira <martin.oliveira@eideticom.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-03-10 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 17:51 [PATCH] ARM/dma-mapping: Remove CMA code when not built with CMA Kees Cook
2022-03-10 7:00 ` Christoph Hellwig
2022-03-10 8:23 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9059fa71-330f-f04f-b155-2850abb72a71@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hbathini@linux.ibm.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=logang@deltatee.com \
--cc=martin.oliveira@eideticom.com \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).