linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Andrew Lunn <andrew@lunn.ch>, Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
	olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org,
	robh+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aleksander Jan Bajkowski <A.Bajkowski@stud.elka.pw.edu.pl>
Subject: Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330
Date: Fri, 4 Dec 2020 13:53:07 +0100	[thread overview]
Message-ID: <905ee9b3-f84e-8af0-d50e-822166c0969e@hauke-m.de> (raw)
In-Reply-To: <20201204014957.GB2414548@lunn.ch>


[-- Attachment #1.1: Type: text/plain, Size: 566 bytes --]

On 12/4/20 2:49 AM, Andrew Lunn wrote:
>>   static const struct of_device_id gswip_of_match[] = {
>>   	{ .compatible = "lantiq,xrx200-gswip", .data = &gswip_xrx200 },
>> +	{ .compatible = "lantiq,xrx300-gswip", .data = &gswip_xrx300 },
>> +	{ .compatible = "lantiq,xrx330-gswip", .data = &gswip_xrx300 },
>>   	{},
> 
> Is there an ID register which allows you to ask the silicon what it
> is?

Yes there is, see GSWIP_VERSION.

> It would be good to verify the compatible string against the hardware,
> if that is possible.
> 
>     Andrew
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-12-04 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 22:03 [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330 Aleksander Jan Bajkowski
2020-12-03 22:03 ` [PATCH 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330 Aleksander Jan Bajkowski
2020-12-04  0:31 ` [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330 Hauke Mehrtens
2020-12-04  1:49 ` Andrew Lunn
2020-12-04 12:53   ` Hauke Mehrtens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=905ee9b3-f84e-8af0-d50e-822166c0969e@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=A.Bajkowski@stud.elka.pw.edu.pl \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).