From: Matthias Brugger <matthias.bgg@gmail.com>
To: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
CK Hu <ck.hu@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com, HS Liao <hs.liao@mediatek.com>
Subject: Re: [PATCH v3 6/9] soc: mediatek: cmdq: add write_s_mask value function
Date: Mon, 21 Sep 2020 18:16:25 +0200 [thread overview]
Message-ID: <9073ff83-ad99-8e40-e25e-360df74435fd@gmail.com> (raw)
In-Reply-To: <1594136714-11650-7-git-send-email-dennis-yc.hsieh@mediatek.com>
On 07/07/2020 17:45, Dennis YC Hsieh wrote:
> add write_s_mask_value function in cmdq helper functions which
> writes a constant value to address with mask and large dma
> access support.
>
> Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Now pushed to v5.9-next/soc
Thanks!
> ---
> drivers/soc/mediatek/mtk-cmdq-helper.c | 21 +++++++++++++++++++++
> include/linux/soc/mediatek/mtk-cmdq.h | 15 +++++++++++++++
> 2 files changed, 36 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 4e86b65815fc..b6e25f216605 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -294,6 +294,27 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx,
> }
> EXPORT_SYMBOL(cmdq_pkt_write_s_value);
>
> +int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx,
> + u16 addr_low, u32 value, u32 mask)
> +{
> + struct cmdq_instruction inst = {};
> + int err;
> +
> + inst.op = CMDQ_CODE_MASK;
> + inst.mask = ~mask;
> + err = cmdq_pkt_append_command(pkt, inst);
> + if (err < 0)
> + return err;
> +
> + inst.op = CMDQ_CODE_WRITE_S_MASK;
> + inst.sop = high_addr_reg_idx;
> + inst.offset = addr_low;
> + inst.value = value;
> +
> + return cmdq_pkt_append_command(pkt, inst);
> +}
> +EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value);
> +
> int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event)
> {
> struct cmdq_instruction inst = { {0} };
> diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h
> index ae73e10da274..d9390d76ee14 100644
> --- a/include/linux/soc/mediatek/mtk-cmdq.h
> +++ b/include/linux/soc/mediatek/mtk-cmdq.h
> @@ -165,6 +165,21 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx,
> u16 addr_low, u32 value);
>
> /**
> + * cmdq_pkt_write_s_mask_value() - append write_s command with mask to the CMDQ
> + * packet which write value to a physical
> + * address
> + * @pkt: the CMDQ packet
> + * @high_addr_reg_idx: internal register ID which contains high address of pa
> + * @addr_low: low address of pa
> + * @value: the specified target value
> + * @mask: the specified target mask
> + *
> + * Return: 0 for success; else the error code is returned
> + */
> +int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx,
> + u16 addr_low, u32 value, u32 mask);
> +
> +/**
> * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet
> * @pkt: the CMDQ packet
> * @event: the desired event type to "wait and CLEAR"
>
next prev parent reply other threads:[~2020-09-21 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 15:45 [PATCH v3 0/9] support cmdq helper function on mt6779 platform Dennis YC Hsieh
2020-07-07 15:45 ` [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump Dennis YC Hsieh
2020-07-08 7:27 ` Bibby Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 2/9] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 3/9] soc: mediatek: cmdq: add write_s_mask function Dennis YC Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 4/9] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 5/9] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 6/9] soc: mediatek: cmdq: add write_s_mask " Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger [this message]
2020-07-07 15:45 ` [PATCH v3 7/9] soc: mediatek: cmdq: add jump function Dennis YC Hsieh
2020-09-21 16:18 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api Dennis YC Hsieh
2020-07-07 23:04 ` Chun-Kuang Hu
2020-09-21 16:19 ` Matthias Brugger
2020-09-21 16:25 ` Dennis-YC Hsieh
2020-07-07 15:45 ` [PATCH v3 9/9] drm/mediatek: reduce clear event Dennis YC Hsieh
2020-07-07 23:01 ` Chun-Kuang Hu
2020-09-21 16:37 ` Matthias Brugger
2020-07-09 2:39 ` Bibby Hsieh
2020-09-21 16:36 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9073ff83-ad99-8e40-e25e-360df74435fd@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=houlong.wei@mediatek.com \
--cc=hs.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).