From: Tero Kristo <t-kristo@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <wim@linux-watchdog.org>, <linux@roeck-us.net>,
<linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCHv2 1/4] dt-bindings: watchdog: Add support for TI K3 RTI watchdog
Date: Wed, 11 Mar 2020 09:48:54 +0200 [thread overview]
Message-ID: <90e0e943-5b84-ba61-1b6f-fe9259415df7@ti.com> (raw)
In-Reply-To: <20200310193721.GA24150@bogus>
On 10/03/2020 21:37, Rob Herring wrote:
> On Mon, Mar 02, 2020 at 10:04:23PM +0200, Tero Kristo wrote:
>> TI K3 SoCs contain an RTI (Real Time Interrupt) module which can be
>> used to implement a windowed watchdog functionality. Windowed watchdog
>> will generate an error if it is petted outside the time window, either
>> too early or too late.
>>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> ---
>> .../bindings/watchdog/ti,rti-wdt.yaml | 52 +++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
>> new file mode 100644
>> index 000000000000..3813f59fb6c3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings please:
>
> (GPL-2.0-only OR BSD-2-Clause)
Ok, will fix this.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/ti,rti-wdt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments K3 SoC Watchdog Timer
>> +
>> +maintainers:
>> + - Tero Kristo <t-kristo@ti.com>
>> +
>> +description: |+
>
> You can drop '|+' as there's no formatting to preserve.
Ok.
>
>> + The TI K3 SoC watchdog timer is implemented via the RTI (Real Time
>> + Interrupt) IP module. This timer adds a support for windowed watchdog
>> + mode, which will signal an error if it is pinged outside the watchdog
>> + time window, meaning either too early or too late. The error signal
>> + generated can be routed to either interrupt a safety controller or
>> + to directly reset the SoC.
>> +
>
> Reference the common watchdog.yaml schema.
I believe you mean just adding:
allOf:
- $ref: "watchdog.yaml#"
>
>> +properties:
>> + compatible:
>> + enum:
>> + - ti,rti-wdt
>
> Should be SoC specific possibly with a fallback.
Ok, will change this.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> +
>> +examples:
>> + - |
>> + /*
>> + * RTI WDT in main domain on J721e SoC. Assigned clocks are used to
>> + * select the source clock for the watchdog, forcing it to tick with
>> + * a 32kHz clock in this case.
>> + */
>> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
>> +
>> + main_rti0: rti@2200000 {
>
> watchdog@...
Right.
>
>> + compatible = "ti,rti-wdt";
>> + reg = <0x0 0x2200000 0x0 0x100>;
>> + clocks = <&k3_clks 252 1>;
>> + power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
>
> Not documented.
For this and assigned-clocks below...
>
>> + assigned-clocks = <&k3_clks 252 1>;
>> + assigned-clock-parents = <&k3_clks 252 5>;
>
> Not documented.
Ok will fix these, I was grepping for examples under the yaml files and
some seem to document these standard props, some not. But, I guess
everything listed in the examples should be documented.
Sorry all this yaml stuff is still pretty new to me. >.<
-Tero
>
>> + };
>> --
>> 2.17.1
>>
>> --
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-03-11 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 20:04 [PATCHv2 0/4] watchdog: add TI K3 SoC watchdog support Tero Kristo
2020-03-02 20:04 ` [PATCHv2 1/4] dt-bindings: watchdog: Add support for TI K3 RTI watchdog Tero Kristo
2020-03-10 19:37 ` Rob Herring
2020-03-11 7:48 ` Tero Kristo [this message]
2020-03-02 20:04 ` [PATCHv2 2/4] watchdog: reset last_hw_keepalive time at start Tero Kristo
2020-03-03 21:12 ` Guenter Roeck
2020-03-02 20:04 ` [PATCHv2 3/4] watchdog: Add K3 RTI watchdog support Tero Kristo
2020-03-03 21:18 ` Guenter Roeck
2020-03-04 6:57 ` Tero Kristo
2020-03-04 9:23 ` Guenter Roeck
2020-03-04 10:42 ` [PATCHv3 " Tero Kristo
2020-03-04 22:06 ` Guenter Roeck
2020-04-01 12:44 ` Tero Kristo
2020-04-01 15:55 ` Guenter Roeck
2020-04-01 17:01 ` Tero Kristo
2020-03-04 10:44 ` [PATCHv2 " Tero Kristo
2020-03-02 20:04 ` [PATCHv2 4/4] arm64: dts: ti: k3-j721e-main: Add MAIN domain watchdog entries Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e0e943-5b84-ba61-1b6f-fe9259415df7@ti.com \
--to=t-kristo@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).