linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ
@ 2021-06-07  3:59 Mark-PK Tsai
  2021-06-08  2:49 ` Mark-PK Tsai
  2021-06-08 14:03 ` Matthias Brugger
  0 siblings, 2 replies; 4+ messages in thread
From: Mark-PK Tsai @ 2021-06-07  3:59 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Thomas Gleixner, Matthias Brugger, linux-kernel,
	linux-arm-kernel, linux-mediatek, mark-pk.tsai, yj.chiang

Only TV SoCs of Mediatek products have this controller
which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected.
Instead, use ARCH_MSTARV7 as default value.

Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 62543a4eccc0..30f578e18a11 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ
  2021-06-07  3:59 [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ Mark-PK Tsai
@ 2021-06-08  2:49 ` Mark-PK Tsai
  2021-06-08 14:03 ` Matthias Brugger
  1 sibling, 0 replies; 4+ messages in thread
From: Mark-PK Tsai @ 2021-06-08  2:49 UTC (permalink / raw)
  To: mark-pk.tsai
  Cc: linux-arm-kernel, linux-kernel, linux-mediatek, matthias.bgg,
	maz, tglx, yj.chiang, daniel

+ Daniel

> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
>  config MST_IRQ
>  	bool "MStar Interrupt Controller"
>  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> -	default ARCH_MEDIATEK
> +	default ARCH_MSTARV7
>  	select IRQ_DOMAIN
>  	select IRQ_DOMAIN_HIERARCHY
>  	help
> -- 
> 2.18.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ
  2021-06-07  3:59 [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ Mark-PK Tsai
  2021-06-08  2:49 ` Mark-PK Tsai
@ 2021-06-08 14:03 ` Matthias Brugger
  2021-06-08 17:52   ` Mark-PK Tsai
  1 sibling, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2021-06-08 14:03 UTC (permalink / raw)
  To: Mark-PK Tsai, Marc Zyngier
  Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, linux-mediatek,
	yj.chiang



On 07/06/2021 05:59, Mark-PK Tsai wrote:
> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
>  config MST_IRQ
>  	bool "MStar Interrupt Controller"
>  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST

We should also delete ARCH_MEDIATEK dependency.

Regards,
Matthias

> -	default ARCH_MEDIATEK
> +	default ARCH_MSTARV7
>  	select IRQ_DOMAIN
>  	select IRQ_DOMAIN_HIERARCHY
>  	help
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ
  2021-06-08 14:03 ` Matthias Brugger
@ 2021-06-08 17:52   ` Mark-PK Tsai
  0 siblings, 0 replies; 4+ messages in thread
From: Mark-PK Tsai @ 2021-06-08 17:52 UTC (permalink / raw)
  To: matthias.bgg
  Cc: linux-arm-kernel, linux-kernel, linux-mediatek, mark-pk.tsai,
	maz, tglx, yj.chiang



> On 07/06/2021 05:59, Mark-PK Tsai wrote:
> > Only TV SoCs of Mediatek products have this controller
> > which inherit from MStar TV SoCs.
> > Don't enable it by default if ARCH_MEDIATEK is selected.
> > Instead, use ARCH_MSTARV7 as default value.
> > 
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> >  drivers/irqchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 62543a4eccc0..30f578e18a11 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> >  config MST_IRQ
> >  	bool "MStar Interrupt Controller"
> >  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> 
> We should also delete ARCH_MEDIATEK dependency.

Actually what I want to do is decouple the MST_IRQ from
ARCH_MEDIATEK, because there are only TV SoCs have this.
But if I remove the ARCH_MEDIATEK dependency, then all the
Mediatek TV SoCs kernel have to select ARCH_MSTARV7 too.
It's kind of weird.

Though it may ask some Mediatek users about MST_IRQ,
I just change the default config to prevent that all
the Mediatek kernel include this driver by default.

What would you suggest for this?

> 
> Regards,
> Matthias
> 
> > -	default ARCH_MEDIATEK
> > +	default ARCH_MSTARV7
> >  	select IRQ_DOMAIN
> >  	select IRQ_DOMAIN_HIERARCHY
> >  	help
> > 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-08 17:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07  3:59 [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ Mark-PK Tsai
2021-06-08  2:49 ` Mark-PK Tsai
2021-06-08 14:03 ` Matthias Brugger
2021-06-08 17:52   ` Mark-PK Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).